[Workloads] Unable to find exposed port for Emojivoto web service about meshery-linkerd HOT 3 CLOSED

@utkarsh-pro This change looks good, please create a PR, ill test and help you get the PR approved for the fix.

from meshery-linkerd.

@leecalcote @kumarabd after searching around for a while I found that here
https://github.com/layer5io/meshery-linkerd/blob/f2aff92347096940739df3a546b684883e14fe1e/linkerd/linkerd.go#L488-L490

we are overriding the namespace that was received and end up creating the resource in the namespace from the YAML file. But when we search for the resource (to look for the port), we search in the namespace given by the user. This is why the deployment is succeeding but service lookup fails. I replaced that with

data.SetNamespace(namespace)

I also changed
https://github.com/layer5io/meshery-linkerd/blob/f2aff92347096940739df3a546b684883e14fe1e/linkerd/linkerd.go#L546
to

- if deleteOpts && dataNamespace.GetName() != "default" {
+ if deleteOpts && dataNamespace.GetNamespace() != "default" {

so that it doesn't attempt delete the default namespace and it seemed to fix the issue. Not creating a PR as I am not sure if these changes will break anything 😅 . Any suggestions?

from meshery-linkerd.

Very zoos, @utkarsh-pro 😀

from meshery-linkerd.