Comments (7)
Does it spawn actual processes? Ours just creates new threads and executes the commands in-process so that code coverage works.
from mesabox.
Oh,that issue is caused by ptrace
-based coverage report tool. Because we are using gcov
(compiler instrumentation-based method), I think we can safely spawn processes and get accurate code coverage report. Anyway, let me verify my thought first.
from mesabox.
It works as expected.
diff --git a/tests/gnu/test_arch.rs b/tests/gnu/test_arch.rs
index e6a4401..7f5863e 100644
--- a/tests/gnu/test_arch.rs
+++ b/tests/gnu/test_arch.rs
@@ -7,13 +7,18 @@
//
use util::*;
+extern crate assert_cmd;
+use std::process::Command;
+use self::assert_cmd::prelude::*;
#[test]
#[cfg(target_arch = "x86_64")]
fn test_x86_64() {
- new_ucmd!()
- .succeeds()
- .stdout_only("x86_64\n");
+ Command::main_binary()
+ .unwrap()
+ .args(&["arch"])
+ .assert()
+ .stdout("x86_64\n");
}
#[test]
from mesabox.
For the issue I mentioned here: https://github.com/rust-lang-nursery/cli-wg/issues/9#issuecomment-385530575
It can be solve with a rustc wrapper: https://github.com/mesalock-linux/mesabox/blob/master/ci/cov-rustc
In this way, we can add coverage-related flags to both mesabox
and tests
crate names.
from mesabox.
I'm not opposed to this change then (assuming assert_cmd
has everything we need, which I haven't verified).
from mesabox.
Sorry, should be assert_cli
. I changed the title accordingly.
Edit: assert_cli
is deprecated. We use assert_cmd
instead.
I'm working on this in this PR: #24
from mesabox.
Merged.
from mesabox.
Related Issues (20)
- init: Is init a POSIX utility? HOT 2
- Better format for error messages HOT 4
- Issues with using the utils as shell built-ins
- sleep: not consistent with the POSIX standard HOT 3
- Do we have a guideline for handling error? HOT 8
- sh: escape sequences in bare words parsed incorrectly HOT 1
- Differences between shells
- Drop actual_path? HOT 5
- sh: switch to LALRPOP? HOT 4
- `cargo fmt` does very little HOT 3
- posix/sh: pipeline_subshell test fails in interactive shell HOT 1
- Remove build targets HOT 3
- posix/sh: parser accepts invalid input HOT 1
- Add a wrapper for splice() HOT 2
- The first two tests are blocking for over 60 seconds in Travis HOT 4
- Write testcases HOT 3
- Test coverage is not accurate HOT 6
- NonZero types
- Bindings for calling from C
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mesabox.