Comments (6)
I'm also having this problem when integrating Merit with Forem and other engines. Namespacing awareness would be great.
from merit.
Thanks for your feedback. Certainly this is a bug, as rules are in these cases ambiguous.
You are right @emq: the only problem in adding the namespace with controller_path
I can see is in https://github.com/tute/merit/blob/master/app/models/merit/action.rb#L41-L42, which may end up calling something like 'admin/users'.singularize.camelize.constantize.find_by_id(target_id)
which would raise a NameError
.
The two options that I can now think of are:
- Strip out the namespacing, to call just
'users'.singularize.camelize.constantize.find_by_id(target_id)
- If we require the
:model_name
option in rules with namespaced controllers, it won't break. That functionality gets called only from https://github.com/tute/merit/blob/master/lib/merit/judge.rb#L36, and the option would override the namespaced controller.
A mix of the two seems like the best options: try the namespaced model, catch a possible NameError
to try the Rule#model_name
option, and display a helpful error message if inexistent or also raises NameError
.
Thanks again for your feedback!
from merit.
Thanks for being on top of things.
The case you mention only raises the NameError if the class does not exist, if there was an Admin::User constant, it would work just fine.
I've manage to get it working by changing controller_name to controller_path in the target_model of the action and on the rules_defined? method.
Then I define the rule as grant_on 'forem/posts#create', :badge => 'commenter', :level => 10, model_name: 'Forem::Post' do |post|
, it may work even without the model_name, not sure.
This has worked for me at least with the badges, but I believe it should work with points and rank as well.
from merit.
When the class exists yes, it would work even without the model_name
option @zamith. When I make the time to write the tests I will merge your tweak and my fallback with nice error message, and release a new version.
from merit.
Great! I'll use my patched version until then, but will be on the lookout for the new version.
from merit.
Version 1.2.1 just released with a small API change (see https://github.com/tute/merit/blob/master/UPGRADING.md).
Thanks for the feedback!
from merit.
Related Issues (20)
- Add/Subtract points: NO Method error HOT 8
- undefined method 'create' for Merit:Action:Class HOT 12
- Use DeviseInvitable with Merit HOT 2
- Display flash messages to notify users when they obtain badges/points HOT 9
- Adding points doesn't work the first time HOT 1
- Display a specific badge and the users who obtained it HOT 2
- Merit 4.0 causing Heroku deployment errors HOT 4
- Typo in active_record/merit_generator task
- Deprecation warning: Expected string default value for '--orm'; got false (boolean). HOT 3
- Granting badges with Devise Registrations#update not working HOT 11
- rails g merit:install don't generating migrations on Rails6 HOT 18
- can't write unknown attribute `sash_id` when calling points method on user HOT 3
- subtract_points is not working HOT 3
- Missing index on merit_actions table for processed HOT 2
- Error on create merit_actions migration file HOT 2
- Score on namespaced/controller#action, can not trigger Merit::Action HOT 6
- Error every time code changes HOT 7
- do not support grape? HOT 1
- Devise & Sign-in then trigger grant_on HOT 12
- On destroy, Integer returned instead of object HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merit.