Git Product home page Git Product logo

Comments (5)

jozef-budac avatar jozef-budac commented on August 22, 2024

This doesn't work well on 2024.3.1 RC at least in two scenarios

  1. when the feature form is empty, the android and top left back button should close the window without any notification or confirmation, but
  • top left button shows "Unsaved changes" window - bug
  • The Android button does nothing - bug
  1. when I fill out the form and hit the top left back button, the "Unsaved changes" window appears. When I click the 'X' button on it to close the modal windows, from not the back Android button does nothing - bug

For the second point, here is the video:
https://github.com/user-attachments/assets/c3457b63-9b83-416f-8e69-1a7678a3897a

from mobile.

tomasMizera avatar tomasMizera commented on August 22, 2024

This doesn't work well on 2024.3.1 RC at least in two scenarios

1. when the feature form is empty, the android and top left back button should close the window without any notification or confirmation, but


* top left button shows "Unsaved changes" window - bug

* The Android button does nothing - bug


2. when I fill out the form and hit the top left back button, the "Unsaved changes" window appears. When I click the 'X' button on it to close the modal windows, from not the back Android button does nothing - bug

For the second point, here is the video: https://github.com/user-attachments/assets/c3457b63-9b83-416f-8e69-1a7678a3897a

Hi @jozef-budac thanks for that, we will have a look at the android button issue. The "unsaved changes" window should be there when creating a new form all the time (even if you did not change anything) as going back will discard the entire captured geometry.

from mobile.

ValentinBuira avatar ValentinBuira commented on August 22, 2024

Hi @jozef-budac thanks for the catch

For 1, the android button bug doing nothing when adding the feature form is empty is already present in last release
And for 2, now the issue also appear after closing "Unsaved changes" dialog

Both got the same root issue; the back event is handled only when the form is in focus, so if you tap on a field again it works again

I'm working on a fix

from mobile.

jozef-budac avatar jozef-budac commented on August 22, 2024

@tomasMizera , the "Unsaved changes" window appears when hitting the back button even for nongeo feature with an empty. form. Are we OK with that?

Screen_Recording_20240807_082826.mp4

from mobile.

tomasMizera avatar tomasMizera commented on August 22, 2024

@tomasMizera , the "Unsaved changes" window appears when hitting the back button even for nongeo feature with an empty. form. Are we OK with that?
Screen_Recording_20240807_082826.mp4

Yeah, I think that is fine for now, thanks for double-checking @jozef-budac

from mobile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.