Incorrect kwarg is not logged or rejected about dashboard-api-python HOT 4 OPEN

Thanks for reporting this @mpenning !

Adding additional error conditions to the library methods could be seen as a breaking change; scripts otherwise working would stop working and this could be a big problem for folks who are not actively maintaining their scripts.

I don't think this is a security concern so it's harder to justify in that sense.

Did you have a suggested approach for handling this? Especially if you have a PR, that'd be helpful.

from dashboard-api-python.

Adding additional error conditions to the library methods could be seen as a breaking change; scripts otherwise working would stop working and this could be a big problem

Today, errors pass silently... and the result is VERY bad... the API returns partial results. That broke my script, but only because I knew exactly how many networks to expect. Imagine if I didn't catch the problem and it broke my production network.

Your claim is essentially "rejecting an invalid keyword could break a running script". The Zen of Python is very clear about this... "Errors should never pass silently... Unless explicitly silenced."

Logging a red error message to stdout seems rather unlikely to be a breaking change. Perhaps we can agree on this point.

from dashboard-api-python.

Adding an entry to the logger with that severity on such a scenario sounds like a good enhancement. Would you like to send a PR making that change?

from dashboard-api-python.

send a PR making that change?

Sounds good... it may take a while, I'm not familiar with the inner working of things

from dashboard-api-python.