Registering output is picking free port incorrectly about membrane_video_compositor_plugin HOT 3 CLOSED

Yep, It was initially done this way since VC didn't have the option to specify port range. It should be fixed.

This works fine as long as the port isn't taken in the meantime (between checking in the plugin and registering on the VC side), but should be done on VC side

from membrane_video_compositor_plugin.

Yep, It was initially done this way since VC didn't have the option to specify port range. It should be fixed.

I'm talking about output stream not inputs. There is no (and it can't ever be) option to specifiy that range in compositor

This works fine as long as the port isn't taken in the meantime (between checking in the plugin and registering on the VC side), but should be done on VC side

I don't think this is true. Unless I missed sth there is no checking at all whether port is free. Request to register output will always succeed regardless whether port if free or not

from membrane_video_compositor_plugin.

Oh, sorry, I got it wrong.

To handle it correctly, we should:

• Try to spawn the UPD source for output and recover by trying the other port in the case of an error (port taken / not available). This could be "optimized" by firstly checking if the port is free (but it can be taken after check - TOCTOU problem).
• After successful spawn of UDP source register output with the request.

Also, for inputs:

• Instead of trying to use individual ports specify a range in the register input request.

from membrane_video_compositor_plugin.