Git Product home page Git Product logo

Comments (4)

hikerspath avatar hikerspath commented on August 11, 2024

This should already be possible with the following triggering:

trigger:
  ref:
    include:
      - refs/heads/feature-*
  paths:
    include:
      - /paths/to/include/**

or on an individual step as follows

step:
  - name: something
    image: something-else:1.0.0
    when:
      ref:
        include:
          - refs/heads/feature-*
      paths:
        include:
          - /paths/to/include/**

See Triggering in drone docs...

from drone-convert-pathschanged.

digitalnomd avatar digitalnomd commented on August 11, 2024

Thanks, but you didn't entirely address my issue. What about adding functionality to trigger the paths changed logic only on a keyword in the commit message?

Also, I don't think the built-in drone triggering logic completely solves the issue with evaluating paths changed logic only on certain branches. Consider that we want to run the step in your example on a master branch, but not include the path change logic there. Then we'd have to create another drone step like so:

step:
  - name: another-thing
    image: something-else:1.0.0
    when:
      ref:
        include:
          - refs/heads/master

That's less ideal than being able to toggle the paths change logic on/off by build branch name, which is part of what I'm proposing because your drone server config file is going to grow rapidly as a result.

from drone-convert-pathschanged.

hikerspath avatar hikerspath commented on August 11, 2024

I will bring this up to the team. As for the drone triggering logic, we work with the triggering logic in place, we do not override the same. If you have any issues with triggering logic, itself that would have to be lodged as a feature request in the drone project (unless I am misunderstanding your request still).

Another option however could be use of environment variables in the commands you send. Then you would have the broad sweep of triggering with a refined action in the command-set itself.

from drone-convert-pathschanged.

hikerspath avatar hikerspath commented on August 11, 2024

We believe there is something in the backlog for drone as a whole that will allow for multiple conversion extensions to function simultaneously. As a project however, we are going to stay focused on paths alone ensuring the ability to perform the conversions of the same. Adding an additional textual filters that are non-path based would degrade the focus we presently have and possibly open up interaction bugs due to the same. We would recommend following the conversation above or reaching out in gitter.im/drone/drone which is monitored by contributors.

from drone-convert-pathschanged.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.