Comments (6)
melMass
commented on June 5, 2024
Good point yes it makes sense since I do for other externals.
Ace is used solely for the editing part of note plus and showdown is for rendering makrdown from note_plus and from the upcoming documentation widget
from comfy_mtb.
daniel-lewis-ab
commented on June 5, 2024
As mentioned, test before pulling.
from comfy_mtb.
melMass
commented on June 5, 2024
As mentioned, test before pulling.
Thanks, given the nature of the PR (huge minified code..) I will do it myself.
I think it's also missing all the utility files (from cdn they are linked properly)
I will quickly look into it now, and if there are no blockers it should be solved soon
from comfy_mtb.
daniel-lewis-ab
commented on June 5, 2024
Fantastic.
…On Tue, Apr 2, 2024 at 1:46 AM Mel Massadian ***@***.***> wrote:
#167 <#167>
As mentioned, test before pulling.
Thanks, given the nature of the PR (huge minified code..) I will do it
myself.
I think it's also missing all the utility files (from cdn they are linked
properly)
I will quickly look into it now, and if there are no blockers it should be
solved soon
—
Reply to this email directly, view it on GitHub
<#166 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC36LN7N34NIKSPZZHMV3KDY3JO5RAVCNFSM6AAAAABFOVEHK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRGMYDEMJTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from comfy_mtb.
melMass
commented on June 5, 2024
It was way more involving than planned since comfy preloads all the scripts in the web folder.
The trick was to add an extra static path to the server!
Let me know if it solves your security concerns
from comfy_mtb.
daniel-lewis-ab
commented on June 5, 2024
Yeah, that should work. Now it isn't technically XSS exposed, and if we
scan the file it'll tell us what we need to know.
…On Tue, Apr 2, 2024 at 9:25 AM Mel Massadian ***@***.***> wrote:
It was way more involving than planned since comfy preloads all the
scripts in the web folder.
The trick was to add an extra static path to the server!
Let me know if it solves your security concerns
—
Reply to this email directly, view it on GitHub
<#166 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC36LN44J7UWTLAWWCFZOHDY3LEX7AVCNFSM6AAAAABFOVEHK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSGM2TSNBYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from comfy_mtb.
Related Issues (20)
- [bug] install script fails on FILM module downloads HOT 4
- pillow version upgraded to 10.0 or above HOT 2
- [bug]Colored Image (mtb) Unable to process batch masks HOT 5
- [feat] save gif node, better gif quality with ffmpeg, replace io.py with my code HOT 4
- [bug] mask to image is shadowed by comfy's builtin HOT 1
- [feat] better image sequence node HOT 1
- [Bug] Note+ node doesn't show text HOT 15
- Feature request for RemBackground HOT 2
- [feat] remove nodes
- [bug] Unable to composite GIF HOT 3
- [bug] Color picker not working HOT 2
- [bug] Float to Floats does not load HOT 1
- [bug] int to number broken HOT 1
- Some of the nodes doesnt work, but the comfy manager shows no errors [bug] HOT 3
- [bug] Note Plus box is empty when exporting workflow as png HOT 1
- [bug] Image compare(mtb) checkerboard
- [bug] Color Correct (mtb) node missing HOT 3
- [bug] batch node cannot to connect the other customer node HOT 3
- [bug] CURVE(mtb) node HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comfy_mtb.