JIntellitype.swingToIntelliType(int) Bug about jintellitype HOT 10 CLOSED

Fixed in 1.3.7

Hi,
now in 1.3.7 does not work ALT_MASK | CTRL_MASK - method returns 0, but should 
probably return 3.

I propose this to group xxx_MASK and xxx_DOWN_MASK:
if ((swingKeystrokeModifier & InputEvent.SHIFT_MASK) == InputEvent.SHIFT_MASK
                || (swingKeystrokeModifier & InputEvent.SHIFT_DOWN_MASK) == InputEvent.SHIFT_DOWN_MASK) {
            mask |= JIntellitypeConstants.MOD_SHIFT;
        }
        if ((swingKeystrokeModifier & InputEvent.ALT_MASK) == InputEvent.ALT_MASK
                || (swingKeystrokeModifier & InputEvent.ALT_DOWN_MASK) == InputEvent.ALT_DOWN_MASK) {
            mask |= JIntellitypeConstants.MOD_ALT;
        }
        if ((swingKeystrokeModifier & InputEvent.CTRL_MASK) == InputEvent.CTRL_MASK
                || (swingKeystrokeModifier & InputEvent.CTRL_DOWN_MASK) == InputEvent.CTRL_DOWN_MASK) {
            mask |= JIntellitypeConstants.MOD_CONTROL;
        }

Have you tested this fix in all scenarios?

Yes, it will handle all combinations of SHIFT, ALT and CTRL keys and treat 
xxxMASK and xxxDOWN_MASK as same single JIntellitypeConstants modifier. I hope 
it was the first intention.

Plus I would consider including InputEvent.META_MASK (equivalent to 
JIntellitypeConstants.MOD_WIN?):

if ((swingKeystrokeModifier & InputEvent.META_MASK) == InputEvent.META_MASK
                || (swingKeystrokeModifier & InputEvent.META_DOWN_MASK) == InputEvent.META_DOWN_MASK) {
            mask |= JIntellitypeConstants.MOD_WIN;
        }

Hi, one more thing. I suppose swingToIntelliType(int swingKeystrokeModifier) 
should not be called from registerHotKey(int identifier, int modifier, int 
keycode) as input modifiers to that method are expected already in jintellitype 
format.

Regards

Can you look at this version I just checked into the /trunk to make sure it 
looks OK?

http://code.google.com/p/jintellitype/source/browse/trunk/src/main/java/com/mell
oware/jintellitype/JIntellitype.java?spec=svn27&r=27

Yes, it's working now.

Awesome thanks for the patch. I will be a new version and put it on the 
downloads page.

Fixed and 1.3.8 uploaded.