Git Product home page Git Product logo

Comments (4)

Exilz avatar Exilz commented on July 24, 2024

1.1.0 should fix this

from react-native-image-gallery.

davidpaulsson avatar davidpaulsson commented on July 24, 2024

I'll try it out! Thanks! 👊

from react-native-image-gallery.

yozman avatar yozman commented on July 24, 2024

@Exilz
doubleTap still not work

from react-native-image-gallery.

Lump01 avatar Lump01 commented on July 24, 2024

I solved double tap zooming and pinch zooming not staying by implementing the following minor code changes in TransformableImage/index.js and ViewTransformer/index.js:

"react-native-image-gallery": "2.1.5"

TransformableImage/index.js

let maxScale = 5;                            // change to whatever you want the max zoom in state to be
let contentAspectRatio;
let width, height; // imageDimensions

if (imageDimensions) {
    width = imageDimensions.width;
    height = imageDimensions.height;
}

if (width && height) {
    contentAspectRatio = width / height;
    // if (viewWidth && viewHeight) {         // code preventing zoom from staying based on image resolution
    //     maxScale = Math.max(width / viewWidth, height / viewHeight); 
    //     maxScale = Math.max(1, maxScale);
    // }
}

ViewTransformer/index.js

onResponderRelease (evt, gestureState) {
    let handled = this.props.onTransformGestureReleased && this.props.onTransformGestureReleased({
        scale: this.state.scale,
        translateX: this.state.translateX,
        translateY: this.state.translateY
    });
    // if (handled) {
    //     return;
    // }

    if (gestureState.doubleTapUp) {

My full patch file for the project is attached and includes a lot of minor changes like

  • adding maxScale prop to component
  • removing all warnings regarding RN Version 0.70.0 and up
  • allowing double tap and pinch zooming regardless of image resolution

react-native-image-gallery+2.1.5.patch

from react-native-image-gallery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.