Git Product home page Git Product logo

Comments (4)

mhdabbaghy avatar mhdabbaghy commented on August 19, 2024

@mehdiyari, I thought that I added all compose dependencies to this module (Material3, Animation, Ui-tooling) so it's not limited to the theme
A better name would be more appropriate.
or considering that we ignore more separation for now and add ":core:designsystem" and add all related design stuff to it (shared drawable, strings, etc) and separate it in the future if needed

from krypt.

mehdiyari avatar mehdiyari commented on August 19, 2024

Hey @mhdabbaghy, Thanks.

The first thing that I want to tell you, based on our convention for modularization, is that we want to use something other than core or base names. We can have the design system modules in the design or shared directory.

:shared:designsystme:theme

from krypt.

mehdiyari avatar mehdiyari commented on August 19, 2024

@mehdiyari, I thought that I added all compose dependencies to this module (Material3, Animation, Ui-tooling) so it's not limited to the theme A better name would be more appropriate. or considering that we ignore more separation for now and add ":core:designsystem" and add all related design stuff to it (shared drawable, strings, etc) and separate it in the future if needed

Having this dependency inside the theme and providing dependencies as API to the rest of the modules is okay. Let's focus on getting the job done, and we can improve it in the future.

from krypt.

mhdabbaghy avatar mhdabbaghy commented on August 19, 2024

Hey @mhdabbaghy, Thanks.

The first thing that I want to tell you, based on our convention for modularization, is that we want to use something other than core or base names. We can have the design system modules in the design or shared directory.

:shared:designsystme:theme

Thanks @mehdiyari
I prefer design than shared,
But as you mentioned, let's get things done, i have no argue on that

from krypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.