Comments (10)
Hey @TomBrien, I removed the deprecation, because the official alternative was just way to cumbersome :/. That being said I just made assets override possible with v2.0.1
, if you haven't switched to @majkrzak's one in the meantime, please do let me know how it works for you :).
from github-release.
I've recreated the action by myself
https://github.com/majkrzak/create-release
from github-release.
If I understand correctly, you have a latest
release that you want to update with each new release - is that correct?
I don't think I've seen that pattern done on Github Releases before, is that a common thing?
from github-release.
Yes, that's my case. I'm building the preview of the LaTeX paper when pushed to the master and publish it as the "Latest draft" preview release. Hadn't saw this approach before and maybe it is not perfect one but it fits my case 😄 Anyway the issue is that allow_override: true
generally does not let you probably override more than body
from github-release.
It should allow you to override everything except assets and tag
, as it's the main identifier.
I actually thought about asset override, but figured that if upload of an asset with the same name is attempted more than once, it's an error, that should be shown to the user. Guess not always 😅.
As for the other things, I'll do more testing to see what's going on.
from github-release.
I'm not saying that my approach is correct. It sounds reasonable that assets are immutable. Maybe only in the "draft" release?
from github-release.
About tag
and commitish
- docs on them say that commitish
is only used if git-tag doesn't exist. If it does exist, it's just used right away instead. And since git-tags and Github Releases, are not exactly the same thing, I'd say force pushing git tags (apart from being "The insane thing" according to git manual 😉), is also out of scope of this action :).
Plus seems like update action does work properly for other fields: https://github.com/meeDamian/github-release/commit/bb75309cfc0b7a207268b4a7a57eb66ef8e85e23/checks
https://github.com/meeDamian/github-release/releases/tag/v0.0.0-test-update
And I still have to think about overriding assets 🤔.
from github-release.
Please use https://github.com/actions/create-release and https://github.com/actions/upload-release-asset now instead.
from github-release.
Please use https://github.com/actions/create-release and https://github.com/actions/upload-release-asset now instead.
Does this comment still apply? I see that the deprecation notice was removed a few days ago, and I agree with the new note! Problem with using actions/create-release and actions/upload-release-asset is it doesn't allow for overwriting releases. I think...
from github-release.
You can always go with mine 🤷♂️ https://github.com/majkrzak/create-release
from github-release.
Related Issues (20)
- 'body' variable not passed as string literal HOT 3
- Body fails when it contains double quotes. HOT 8
- Parameter to keep X oldest releases and delete the rest HOT 3
- v3.0
- Support cross platform HOT 4
- [Feature] upadate body from path
- Fail to run under windows HOT 4
- Add extra option to the compression options
- pass environment variables as file HOT 2
- Impossible to update draft release
- Escape newlines in "body" not work as intended HOT 1
- Unable to override assets on existing release HOT 3
- does not trigger workflows with "on release" action HOT 1
- Ignore failure to delete previous release artifacts HOT 8
- Intermitten SSL issues
- drafts no longer overriden HOT 1
- Spaces in file names cases upload step to not work. HOT 1
- Do globs work in `files`?
- Add support for regular zip HOT 5
- Container action is only supported on Linux HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-release.