[Bug Report] native_event_loop: Hot restart interrupts the listening of events about media-kit HOT 7 CLOSED

Yep

from media-kit.

👏👏👏 May you please raise a PR.
AFAIK only removing send port should also work. I'm surprised how it kept working on Windows & Linux. NEVERMIND!

from media-kit.

Is it really happening?
Once hot restart takes place, a different instance of Player with different mpv_handle* should be created.
So, new event loop should be registered for it.

Ideally, I'd like to clear all Player instances upon a hot-restart, but since our whole implementation is completely in Dart, it's going to be a bit challenging. Maybe, we can request users to call some initialization method before runApp, where we can internally clear existing resources & event threads.

from media-kit.

Shouldn't this be happening even without native event loop?

Eitherway, maybe we can dedicate native event loop to dispose tasks upon hot-restart.
Is there any way to listen to application lifecycle?

flutter/flutter#10437

from media-kit.

I have just tested with main, the video is playing, without the duration or the position being updated. But when I don't use the native event loop, everything works fine.

This may be a problem specific to the Flutter runtime on macOS.

from media-kit.

And it's working before hot-restart?

from media-kit.

Ok, I think I found where the bug came from: media_kit_native_event_loop/src/media_kit_native_event_loop.cc#L21-L27

When I skip the conditions, the events are sent after the hot restart.

// if (post_c_object_ == nullptr) {
  post_c_object_ =
      reinterpret_cast<bool (*)(Dart_Port, Dart_CObject*)>(post_c_object);
// }
// if (send_port_ == -1) {
  send_port_ = send_port;
// }

from media-kit.