Git Product home page Git Product logo

Comments (6)

cringerjs avatar cringerjs commented on May 24, 2024

Since the syntax is applied to .blade and .blade.php extensions it wouldn't make sense to start a new branch. The syntax file should remain compatible with both versions of laravel. I submitted a pull request adding the l4 template changes; essentially the use of @extends (instead of @layout) and @EnD (instead of @yield_section and @endsection). If there are more I'd just send a pull request to the dev and or master branch.

from laravel-blade.

Medalink avatar Medalink commented on May 24, 2024

I think a desperate repo that users can install for L4 might be best. Thoughts?

from laravel-blade.

Medalink avatar Medalink commented on May 24, 2024

Separate*

from laravel-blade.

cringerjs avatar cringerjs commented on May 24, 2024

The only problem with that is that the user would have to specifically choose which version to install. Since they both apply to the blade/blade.php fileType you wouldn't be able to have both of them installed; at least Sublime wouldn't know which to apply based on the file extension. At the moment Laravel4 is in Beta1 so a lot of people are still developing on both versions. Personally I think it would be best by just adding the Laravel4 syntax to the current repo so it works on both versions.

from laravel-blade.

arvidbjorkstrom avatar arvidbjorkstrom commented on May 24, 2024

I agree with @cringer as it is under development just adding the new keywords would be the best idea.
The only argument I can find to the opposite is that you might get confused why commands that are highlighted in the syntax aren't working. But that's a minor issue.

Btw. @cringer - take a look at my comment on your pull request #16

from laravel-blade.

Medalink avatar Medalink commented on May 24, 2024

These have been merged in.

from laravel-blade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.