Comments (5)
hi, i would like to do this one tomorrow :)
Can you assign me to this issue?
from survol.
Hi @mdolr thanks for assigning me and the well documented first issue :)
I opened a PR regarding this Issue: #114
Because the Stackexchange-API requires a site (e.g. physics) i replaced the getDomain() method with a getSite() method. I would appreciate a review.
from survol.
Ok I might have not been clear enough in the issue, I was expecting you to find a way to include every site from the stackexchange network which means everything listed here as the stackexchange network operates on multiple domains. There might be an API call that we could fire when the extension starts to get every domain from the stackexchange network and then use that.
It seems we can get a list of stackexchange websites using GET /sites. This would have to be done at the start of the extension in the background script I guess
from survol.
This is already ok-ish as most of the domains are [something].stackexchange.com and I'll merge this if it's not possible to include everything, but it would save us some time in the future if they open a new website like superuser.com for example, we wouldn't have to add it manually.
from survol.
Ok, thanks for further explaination. I'll try to find an universal solution during the next 2-3 days
from survol.
Related Issues (20)
- Implement direct link to images HOT 2
- Make the survol preview interactive HOT 2
- The survol container should display a placeholder / loading icon HOT 6
- Implement soundcloud profile pages HOT 1
- Onboarding page HOT 2
- List of missing translations : HOT 8
- Rework the landing page HOT 9
- Add a blacklist to deal with website that already have a preview for inner links HOT 18
- The survol container is removed from the DOM in SPA
- Add a badge on the extension icon HOT 1
- Add custom templates for websites supporting oEmbed
- Cache the changelog on onboarding page HOT 2
- Feature request: thumbshots/previews of all websites HOT 3
- Feature request: Inject in existing web pages HOT 1
- Add some indicator while fetching the preview HOT 1
- Make a version for Microsoft Edge HOT 2
- Customizable Wait-Time HOT 1
- SPF +all mechanism should not be used at survol.me
- [Bug] - Make Inoreader hard to load
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from survol.