Comments (9)
andymckay
commented on August 19, 2024
Yeah that's not great but I wanted to keep the add-on really simple and the focus of the add-on is on the history deleter API not on the length. Saying that if, someone wanted to send a really simple pull request that fixed this, that would be cool.
from webextensions-examples.
kartik95
commented on August 19, 2024
Fixed the bug. Pull request #101
from webextensions-examples.
kartik95
commented on August 19, 2024
Will my PR be merged anytime soon? Or does it need any changes? @andymckay
I request you to please add 'hacktoberfest' label to this issue before merging. It would really help me. Thanks!
from webextensions-examples.
wbamberg
commented on August 19, 2024
Fixed by #101.
from webextensions-examples.
wbamberg
commented on August 19, 2024
@vasilicamihasca , could you verify the fix, please?
from webextensions-examples.
vasilicatamas
commented on August 19, 2024
I am still able to reproduce this issue on Firefox 51.0a2 (2016-10-14) under Windows 10 64-bit.
I am not sure but it might be a regression here. Because I noticed that on Firefox 49.0.1 successfully appears a scrollbar and the URL’s are correctly displayed.
from webextensions-examples.
wbamberg
commented on August 19, 2024
Yes, I see this too. I think we should file a Firefox bug for this. @vasilicamihasca , since you found it, do you mind filing?
from webextensions-examples.
vasilicatamas
commented on August 19, 2024
Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1310947
from webextensions-examples.
wbamberg
commented on August 19, 2024
Thanks @vasilicamihasca ! Since this is confirmed as a Firefox bug, we can close this. Thanks also @kartik95 for improving the look of the panel in the example.
from webextensions-examples.
Related Issues (20)
- Favourite Color bug manifest HOT 11
- Native messaging example doesn't pong after a while HOT 3
- browser is not defined in firefox HOT 3
- Can't get response in Ubuntu HOT 10
- Python Native Messaging host does not process 1MB input HOT 11
- Image is not loading by innerHTML in the content-script-register HOT 3
- Create an example of getting select text to a variable HOT 2
- Please add example for "Paste text from clipboard" HOT 5
- examples.json should include a way to list significant manifest keys
- Update eslint, fix linting errors and integrate in CI
- MV3 example for getting data from page/content script/activeTab context into action / popup HOT 3
- Broken root-cert-stats due to var -> let change HOT 6
- Firefox Load temporary addon not working HOT 12
- native-messaging app example: provide non-contrived example for each platform HOT 1
- Update root-cert-stats to use runtime.sendMessage HOT 3
- zip does not contain a valid manifest HOT 2
- Examples disabled when run via web-ext or from folder (applyCSS, borderify) HOT 9
- minor bug with native messaging example HOT 2
- native messaging example: port disconnects without an error HOT 14
- devtools-panels example broken with manifest v3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webextensions-examples.