Git Product home page Git Product logo

Comments (4)

wbamberg avatar wbamberg commented on August 19, 2024

Thanks for reporting this. Which version of Firefox are you using?

I think tabs.move() is only supported from Firefox 46, and tabs.duplicate() from Firefox 47. You should be able to check this using the "Browser Compatibility" section of the API reference docs:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Tabs/move#Browser_compatibility
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Tabs/duplicate#Browser_compatibility

As such, this add-on is only fully functional on Firefox 47 and up (and it works fine for me on Firefox 47, and fails as expected on Firefox 45).

A way to check this for an add-on is using the "strict_min_version" key in the add-on's manifest.json: https://github.com/mdn/webextensions-examples/blob/master/tabs-tabs-tabs/manifest.json. In fact, I thought that this should have prevented the add-on from installing in earlier versions but it seems like it doesn't. I think this might be a bug.

So, please let me know if it works in Firefox 47. If so, I'll close this (and maybe file another bug about strict_min_version).

from webextensions-examples.

khanstark avatar khanstark commented on August 19, 2024

I was using firefox 45.0.1 while testing this add-on. But I have updated to 47[developer edition] now, and yeah 'strict_min_version' needs to rectified because it didn't prevent installation on earlier versions, as obvious.

from webextensions-examples.

khanstark avatar khanstark commented on August 19, 2024

It works fine in 47, but you need to look at the above issue of 'strict_min_version'.

from webextensions-examples.

wbamberg avatar wbamberg commented on August 19, 2024

'strict_min_version' is respected in FIrefox 47 and above: https://bugzilla.mozilla.org/show_bug.cgi?id=1192437.

from webextensions-examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.