Comments (7)
The code sample has "logger.log()" not "console.log()". Is there a reason for this? I'd have thought console would be more obvious.
I changed it to logger
. The reason is that should you try to actually .log
, .dir
or anything like that when debugging the live editor code, this override swallows it :-/
from interactive-examples.
Yes, that makes sense. I don't know if you changed the implementation of console
, but in the original it was pretty basic!
from interactive-examples.
I'd like to reopen this. Feedback in our testing in SF was that "logger" was confusing. I think at least we should reconsider whether to use "console".
from interactive-examples.
@wbamberg Actually, the way I refactored the code, would allow us to do that now. The problem previously was that the variables and function were all exposed to the global object and so, our console
was overriding the global console
. I will make this change.
from interactive-examples.
No, I take that back. For it to work with the examples it needs to be exposed to the global object which means we will be overwriting the global console :-/
from interactive-examples.
Ok, never mind again ;) Turns out there is a way to have the best of both.
from interactive-examples.
Resolved in #97
from interactive-examples.
Related Issues (20)
- Prettier config deviates from mdn/content HOT 2
- Article element in a wrong implementation HOT 5
- :nth-child - update example to be inclusive HOT 5
- `npm install` has `2 vulnerabilities (1 moderate, 1 high)` HOT 2
- `1 moderate severity vulnerability` when running `npm install` HOT 2
- `Array.prototype.reduce()` demo requires horizontal scrolling HOT 7
- Expected output is wrong HOT 2
- Live example on the groups and backreferences page has inconsistent name HOT 3
- try it confusion HOT 2
- css.properties.backdrop-filter - The Firefox WebDev tool says invalid property name although it is running latest edition HOT 1
- Create an interactive example for `HWB()` HOT 5
- Example HTML Dialog HOT 3
- unnecessary css property in an interactive element HOT 3
- 'space-evenly' (and maybe others) in the demo looks odd given the use of grid-gap HOT 1
- Primary application A is nested with subapplication B, and subapplication B is nested with subapplication C. The font icon of subapplication C cannot be displayed HOT 2
- The license in "package.json" and "package-lock.json" is different from the one in "LICENSE" file HOT 2
- Bad practise in examples (prefixed property last) HOT 4
- Change color of `<p>` element in `<dialog>` element to make it visible. HOT 3
- the interactive sections are way too narrow to be shown properly HOT 3
- input.hidden = "true" in the example JS prevents it working HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from interactive-examples.