Git Product home page Git Product logo

Comments (5)

schalkneethling avatar schalkneethling commented on July 20, 2024

I is odd that it does not use Open Sans for the font, will have a look at that. I am wondering, should that heading perhaps utilise Zilla? That way it would just be another section heading and would use the same style as the other headings with the new design.

I can include a very small subset of just what I need in the iFrame if we decide to do this. Thoughts @wbamberg @stephaniehobson

from interactive-examples.

stephaniehobson avatar stephaniehobson commented on July 20, 2024

iframes don't pick up the styles of their parent pages, so, no Open Sans for us :/

I think there are a few options:

  1. use a sans-serif font
  2. remove the explanatory text (it was removed from the original design because no one was reading it in user testing, though probably it is a good thing to A/B test in the long run)

* I don't think using Open Sans or Zilla are good options because the entire font family would have to be downloaded a second time by the client. We can't use the same files that kuma does because they are versioned so we would either be linking to a versioned file that could have the version number change or to a different un-versioned file :/

from interactive-examples.

schalkneethling avatar schalkneethling commented on July 20, 2024

use a sans-serif font

Indeed. Just noticed the font-family is not being set in the body CSS rule. Let me add that. Does not make sense to load the whole font family for this. sans-serif will be close enough.

from interactive-examples.

schalkneethling avatar schalkneethling commented on July 20, 2024

Added in #96

from interactive-examples.

schalkneethling avatar schalkneethling commented on July 20, 2024

Duping in favour of #103

from interactive-examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.