Git Product home page Git Product logo

Comments (7)

stephaniehobson avatar stephaniehobson commented on June 19, 2024

Notes from our in-person meeting:

We want the iframe to be inserted onto the page at different sizes depending on the available width on the page and based on the space necessary for the example. Unfortunately the iframe and the page it's on can't communicate about styling.

So we decided to use 3 different predefined widths, applied by passing a class into the macro when it is added to the page.

I would like us to add the class live to all the iframes and the modifier class live- for sizes.

<iframe class="live live-small" src="....

The classes and corresponding heights are:

aprox lines single side by side class
js x 5 250px 250px live-small
css x 5 400px 200px
css x 10 600px 400px live-large

I think the best way to decide how wide the space has to be before we flip to the side-by-side width is for @schalkneethling to look at the design and say what the minimum amount of necessary space is and then we can write the CSS declarations based on a combination of which columns the page has and how wide it is (this will get complicated).

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

@stephaniehobson Did we want to default to small and so, we only need to set live-large when needed? or perhaps live-tall?

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

Ok, so this is side by side at 210px

screen shot 2017-06-07 at 16 49 00

And this is side by side at 400px

screen shot 2017-06-07 at 16 49 42

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

Another question here is whether:

  1. We want to allow comment(I think they can be useful at times)
  2. Limit these comments to only ever take up one line

Thoughts @stephaniehobson @wbamberg ?

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

So, here is an example where there is more than 5 but, less than 10

screen shot 2017-06-07 at 17 33 56

from interactive-examples.

wbamberg avatar wbamberg commented on June 19, 2024

We want to allow comment(I think they can be useful at times)

I think they can be useful if used carefully and quite sparingly. I don't want them to be the documentation :).

Limit these comments to only ever take up one line

I think this is a good goal.

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

Agreed, I added some comments to the README to reiterate this.

from interactive-examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.