Git Product home page Git Product logo

Comments (4)

anaran avatar anaran commented on May 27, 2024

Ah, these being sample extensions themselves, you must be using something like
cfx -v test
in each example's root directory.

Are all these samples passing for you?

from addon-sdk-content-scripts.

anaran avatar anaran commented on May 27, 2024

After installing latest firefox-trunk on my ubuntu system I got many tests to pass, running

addon-sdk-content-scripts$ for i in `ls`; do if [ -d $i ]; then pushd $i; \
cfx test -b `which firefox-trunk`; popd; fi; done

Some tests still fail, e.g.

console.log: page-mod-content-script-insulation: Windows open:
console.log: page-mod-content-script-insulation: chrome://browser/content/browser.xul - about:blank, resource://jid1-wm9xkrpezttd9q-at-jetpack/page-mod-content-script-insulation/data/page.html
console.log: page-mod-content-script-insulation: null

2 of 4 tests passed.

The following tests failed:
  page-mod-content-script-insulation/tests/test-main.test main: failure
  page-mod-content-script-insulation/tests/test-main.test main async: failure

Total time: 9.620782 seconds
Program terminated unsuccessfully.
(addon-sdk)adrian@apa:~/eclipse-orion-ws/ad/adrian/OrionContent/addon-sdk-content-scripts/page-mod-content-script-insulation$ 

from addon-sdk-content-scripts.

wbamberg avatar wbamberg commented on May 27, 2024

@anaran : they don't really have any tests :(. The test files that are included are just the boilerplate ones that "cfx init" generates. Some of the tests would be pretty hard to write I think, and some are dependent on specific Firefox versions.

Although tests would be nice, I'm not sure whether it's worth adding them rather than spending time on having more documentation of the samples (or more samples, even). The main README includes a one-liner for each add-on: https://github.com/mdn/addon-sdk-content-scripts/blob/master/README.md but it would probably be worth having something a bit more elaborate.

The test you quoted is I think failing because the example is intended to demonstrate a failure case: that content scripts can't see expando properties added by page scripts: https://developer.mozilla.org/en-US/Add-ons/SDK/Guides/Content_Scripts#Accessing_the_DOM.

from addon-sdk-content-scripts.

anaran avatar anaran commented on May 27, 2024

I like the main README with its links to all the important places.

Thanks for confirming the status of the tests.

I consider my issue closed with that.

from addon-sdk-content-scripts.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.