[2.2.013, Paper 1.21-37 (latest as of this report)] Super Breaker/Giga Drill Breaker granting Luck of the Sea instead of Efficiency about mcmmo HOT 5 CLOSED

I am having this same issue!

from mcmmo.

After checking the discord, there were discussions that the issue may not occur with regular Spigot, and only occurs with Paper.
I have tested it with 1.21 Spigot, and Super Breaker works just fine. This points the issue towards Paper.

from mcmmo.

Could this issue be because Paper now by default is Mojang mapped?
I have solved the issue by changing the functions like initEfficiency()

Instead of having the for loop:

for (Enchantment enchantment : Registry.ENCHANTMENT) {
    if (enchantment.getKey().getKey().equalsIgnoreCase("EFFICIENCY")
            || enchantment.getKey().getKey().equalsIgnoreCase("DIG_SPEED")
            || enchantment.getName().equalsIgnoreCase("EFFICIENCY")
            || enchantment.getName().equalsIgnoreCase("DIG_SPEED")) {
        return enchantment;
    }
}

I replaced it with the following:

if (Registry.ENCHANTMENT.get(NamespacedKey.minecraft("efficiency")) != null)
{
	return Registry.ENCHANTMENT.get(NamespacedKey.minecraft("efficiency"));
}

from mcmmo.

I don't think Paper being Mojang mapped has anything in particular to do with this, but I'm not certain of it either. In mcMMO we don't really use any NMS, so the mappings shouldn't affect us. I'm looking into this issue, which may be a Paper bug, or may be something I need to change on my end.

from mcmmo.

Could this issue be because Paper now by default is Mojang mapped? I have solved the issue by changing the functions like initEfficiency()

Instead of having the for loop:

for (Enchantment enchantment : Registry.ENCHANTMENT) {
    if (enchantment.getKey().getKey().equalsIgnoreCase("EFFICIENCY")
            || enchantment.getKey().getKey().equalsIgnoreCase("DIG_SPEED")
            || enchantment.getName().equalsIgnoreCase("EFFICIENCY")
            || enchantment.getName().equalsIgnoreCase("DIG_SPEED")) {
        return enchantment;
    }
}

I replaced it with the following:

if (Registry.ENCHANTMENT.get(NamespacedKey.minecraft("efficiency")) != null)
{
	return Registry.ENCHANTMENT.get(NamespacedKey.minecraft("efficiency"));
}

Thanks for this info, I was able to come up with a workaround

from mcmmo.