test_certs.h should be a generated file about mbedtls HOT 5 CLOSED

On second thoughts, I'm not sure about this. I had missed that test_certs.h only depends on the content of the tests/data_files directory. Files in this directory almost never change, so it is not a problem to commit files that are generated from them. It is, however, relatively common to add files to this directory, and that requires updating test_certs.h. Furthermore adding two files in parallel may lead to an add-add conflict when merging. So I'm still leaning towards thinking that test_certs.h should be generated as part of make generated_files (and cmake etc. equivalents).

Other reasons why we commit files in tests/data_files are that many files require special tooling (e.g. I think at the moment there isn't a single version of openssl that works for all the targets in tests/data_files/Makefile), and the output is randomized. This doesn't apply to the process that generates test_certs.h.

from mbedtls.

Maybe related to the generation issue, but the windows build complains that "test_certs.h" is not found, even after a successful run of make generated_files.bat. (Which depends on setting a CC environment variable, which is not set by default and is not documented.) I think it is an issue of search path for include files in the VS2017 project. It works fine if I add "tests/src" to the search path.

from mbedtls.

"test_certs.h" is not found, even after a successful run of make generated_files.bat.

This is fixed by #9017 .

I think it is an issue of search path for include files in the VS2017 project.

Is it? test_certs.h is only included with #include "test_certs.h" from a file in the same directory, so the search path shouldn't matter.

from mbedtls.

Resolved by #9017

from mbedtls.

Which depends on setting a CC environment variable, which is not set by default and is not documented.

Fair point. #9128

from mbedtls.