Git Product home page Git Product logo

Comments (8)

MFlisar avatar MFlisar commented on August 25, 2024 1

Done, rest can be discussed in the PR

from modernandroidpreferences.

MFlisar avatar MFlisar commented on August 25, 2024 1

Ok, no problem. Good luck with your exams.

from modernandroidpreferences.

MFlisar avatar MFlisar commented on August 25, 2024 1

No need to hurry if this is just "for me".

I've written my own library in the meantime because I wanted quite some more changes (a core that works with async operation via kotlin flows based on suspend functions, preference declarations via delegates, abstract storage with a data store based default implementation, the ability to observe change events of the storage, abstract dependencies between preferences, ...) - my screen module does even use a few small parts of your library as I've written into my credits region, so thanks for this here as well.

from modernandroidpreferences.

Maxr1998 avatar Maxr1998 commented on August 25, 2024

Definitely! I already planned to integrate JetPack DataStore, however, I wanted to wait while it's still in beta. Already having an abstraction for storage providers makes a lot of sense though, so I appreciate the work you've done and would be happy if you opened a PR. I've looked at the code already and it looks mostly good, I'll probably still have some nitpicks to be adressed before merging 😄
Let's discuss those in the PR though.

from modernandroidpreferences.

Maxr1998 avatar Maxr1998 commented on August 25, 2024

I prefer to keep this open until the PR is merged ^^

from modernandroidpreferences.

MFlisar avatar MFlisar commented on August 25, 2024

Any plans on implementing this soon? Or one working on my PR (together if you want)?

from modernandroidpreferences.

Maxr1998 avatar Maxr1998 commented on August 25, 2024

Definitely still planned, but I'm absolutely packed with work (bachelor thesis) right now. Your PR looks good, but there are some things I'd like to change about it. I'll revisit it not later than May, after I finished my bachelor thesis.

from modernandroidpreferences.

Maxr1998 avatar Maxr1998 commented on August 25, 2024

Just as a heads-up: I'll try to get this in soon, but probably not in the next version. Want to get some fixes out first.

from modernandroidpreferences.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.