Comments (8)
Done, rest can be discussed in the PR
from modernandroidpreferences.
Ok, no problem. Good luck with your exams.
from modernandroidpreferences.
No need to hurry if this is just "for me".
I've written my own library in the meantime because I wanted quite some more changes (a core that works with async operation via kotlin flows based on suspend functions, preference declarations via delegates, abstract storage with a data store based default implementation, the ability to observe change events of the storage, abstract dependencies between preferences, ...) - my screen module does even use a few small parts of your library as I've written into my credits region, so thanks for this here as well.
from modernandroidpreferences.
Definitely! I already planned to integrate JetPack DataStore, however, I wanted to wait while it's still in beta. Already having an abstraction for storage providers makes a lot of sense though, so I appreciate the work you've done and would be happy if you opened a PR. I've looked at the code already and it looks mostly good, I'll probably still have some nitpicks to be adressed before merging 😄
Let's discuss those in the PR though.
from modernandroidpreferences.
I prefer to keep this open until the PR is merged ^^
from modernandroidpreferences.
Any plans on implementing this soon? Or one working on my PR (together if you want)?
from modernandroidpreferences.
Definitely still planned, but I'm absolutely packed with work (bachelor thesis) right now. Your PR looks good, but there are some things I'd like to change about it. I'll revisit it not later than May, after I finished my bachelor thesis.
from modernandroidpreferences.
Just as a heads-up: I'll try to get this in soon, but probably not in the next version. Want to get some fixes out first.
from modernandroidpreferences.
Related Issues (16)
- How to specify a summary that contains the current value of the preference HOT 4
- Add default value for more EditTextPreference HOT 2
- Create custom preferences HOT 1
- Whether or not an icon is set, there will be a margin on the left, whether the margin can be removed HOT 2
- Dependency Dashboard
- Custom dialog style for choice preferences HOT 2
- Screenshots and/or embed videos for README HOT 1
- [SeekBarPreference] Change listener + DSL to set it easily
- Add option to show multiline preference titles HOT 1
- Action Required: Fix Renovate Configuration
- Implement an `EditTextPreference` counterpart HOT 2
- Setting `collapseIcon = true` does not work HOT 3
- Subscreens should inherit `collapseIcon` and other screen properties from parent
- multiChoice preference doesn't show summary HOT 4
- Option to set default option in SingleChoice preference HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modernandroidpreferences.