Git Product home page Git Product logo

Comments (4)

maxkeppeler avatar maxkeppeler commented on July 30, 2024

You only want to make the text itself scrollable, or the whole layout container in which it is placed? I see that more of an improvement than a bug though. It is expected that the height of the sheet increases with the size of the content added.

from sheets.

irvine752 avatar irvine752 commented on July 30, 2024

I think having the whole component scrollable would be best for all the sheets. I can see instances where you have other components other than the Text being bigger than the screen size.

I marked it as a bug since I figured the default behaviour wasn't accounting for the excessive growth in Text. I think the enhancement portion would the ability to set the default height as a maybe a % of the screen height.

from sheets.

maxkeppeler avatar maxkeppeler commented on July 30, 2024

The sheet types that offer flexible content (e.g. InputSheet, OptionsSheet, ColorSheet) are scrollable. I will not add a universal support for scrolling. If someone wants to create a custom implementation, they should be able to control that as they want.

I was spending some thoughts on making the InfoSheet more flexible, or keep it simple and add images, animation, text and other components to the InputSheet (despite being more of a visual content builder than actual input).

No matter what I end up doing, it makes sense to limit the height of the view, though I would define a maximum height for the content container, not the whole bottom-sheet/ dialog, and make it scrollable. I will try to work on that on the weekend.

from sheets.

irvine752 avatar irvine752 commented on July 30, 2024

No worries, that works for me. If the other sheets that offer other components are scrollable that's perfect. That was a bad assumption on my part to assume it's the same behavior for the other sheets.

from sheets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.