Comments (4)
You only want to make the text itself scrollable, or the whole layout container in which it is placed? I see that more of an improvement than a bug though. It is expected that the height of the sheet increases with the size of the content added.
from sheets.
I think having the whole component scrollable would be best for all the sheets. I can see instances where you have other components other than the Text being bigger than the screen size.
I marked it as a bug since I figured the default behaviour wasn't accounting for the excessive growth in Text. I think the enhancement portion would the ability to set the default height as a maybe a % of the screen height.
from sheets.
The sheet types that offer flexible content (e.g. InputSheet, OptionsSheet, ColorSheet) are scrollable. I will not add a universal support for scrolling. If someone wants to create a custom implementation, they should be able to control that as they want.
I was spending some thoughts on making the InfoSheet more flexible, or keep it simple and add images, animation, text and other components to the InputSheet (despite being more of a visual content builder than actual input).
No matter what I end up doing, it makes sense to limit the height of the view, though I would define a maximum height for the content container, not the whole bottom-sheet/ dialog, and make it scrollable. I will try to work on that on the weekend.
from sheets.
No worries, that works for me. If the other sheets that offer other components are scrollable that's perfect. That was a bad assumption on my part to assume it's the same behavior for the other sheets.
from sheets.
Related Issues (20)
- Color: TextView overlaps SeekBar HOT 2
- Localization: consider using platform resources HOT 1
- onNegative / onPositive support for dynamic drawables
- Text content on OptionSheet HOT 1
- Option constructor with long click listener without specifying sub-text. HOT 2
- Core module leaking colour attributes into consuming applications HOT 1
- make bottom sheet form scrollable HOT 1
- Option customisation support HOT 1
- Cannot use textview on bottomsheet HOT 3
- How to modify the size of the TextView of OptionSheet? HOT 1
- ColorSheet For Jetpack Compose. HOT 4
- CharSequence to the rescue
- Positive button should be invisible or unclickable.
- Custom year range in CalendarSheet HOT 1
- Text/Icons not centered when using OptionSheet as dialog HOT 1
- Upgrade to material 3. HOT 1
- Looping for option sheet HOT 1
- prevent dismiss
- Months Layout
- `rememberSheetState` and `rememberLauncherForActivityResult` not working together in the same page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sheets.