Git Product home page Git Product logo

Comments (6)

irvine752 avatar irvine752 commented on July 30, 2024 1

Yep, I love the stuff I have seen so far. The top views should be more than enough for all the use cases. The SheetStyle is great for options, but you might have to change the name of the project though. :)

The icon background color would be a great addition. Looking forward to the next release!

from sheets.

maxkeppeler avatar maxkeppeler commented on July 30, 2024

With text at the bottom, you mean the title below the cover image / Lottie animation?

from sheets.

irvine752 avatar irvine752 commented on July 30, 2024

yep, having it below the cover image/Lottie animation would work well. I just saw the updates in 1.1.2. The title placement you have already looks great so far, not sure if you already added the Lottie option yet.

For the icons on the image area for the Overlapping Cover Image, I would have a contrast background. I'm guessing you're setting android:src to the icon drawable, there's also android:background which should be a white circle if the icon is black. That way it's easier to see the black icons on a black or dark image.

from sheets.

maxkeppeler avatar maxkeppeler commented on July 30, 2024

Great to hear. Did you notice the 3 styles for the top view?

I did not work on Lottie animations yet.
I want to offer it as an add-on library, with which the cover image view is used to display Lottie animations and offering several more helper methods regarding that. I think it would bloat the default base library too much if it's by default included. First, I first have to figure out how I implement this though.

If you checked out the latest work for the next release, did you play around with the style(SheetStyle) available for every sheet? It displays the view as either a dialog or a bottom-sheet.

from sheets.

maxkeppeler avatar maxkeppeler commented on July 30, 2024

You are correct with the note on the missing contrast. It's possible to specify the colors for the icon buttons, so if it's known that the image is bright, dark colors can be used for the icons for a better contrast. That's correct, I'm setting the src for the icon drawable. However, I'm using the background for a ripple drawable.
When I have time, I will work on an option for the IconButtons to specify a background color, which will be seen as a round circle in the respective color behind the icon buttons!

from sheets.

maxkeppeler avatar maxkeppeler commented on July 30, 2024

I will, probably to just "Sheets". Ehm. Not sure when though, I would want to change the dependency names and general structure of the modules then too.

from sheets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.