Bug in Circuit Library Generation about equivalentcircuits.jl HOT 8 CLOSED

Hi I am following up - do you have any feedback?

from equivalentcircuits.jl.

Hi Ben,

There appears to be an issue with your input. For this function to work properly, the parameters corresponding to CPEs should be placed within square brackets. Also, there are too many square brackets in your circuit notation (a correct circuit notation has as many sets of square brackets as commas).

circuit_init="R1-[P2-[P3,R4],C5]"
initial_guess= [249.3712, [8.9111e-09, 0.9175], [2.2931e-10, 0.9552], 78528.9522, 8.3193e-15]

That being said, I did notice these old functions needed a syntax update, which I have now implemented. The add_to_circuitlibrary function should work properly now, given that you already have a circuit library initiated and use the above inputs.

from equivalentcircuits.jl.

I pulled the latest version from github, but i'm still getting "no method matching min()" error as shown in the gist I sent.

Do you have any other suggestions?

from equivalentcircuits.jl.

i have confirmed that, to the best of my knowledge and someone more knowledgeable than me, that i reinstalled the package and the dependencies properly.

from equivalentcircuits.jl.

Did you use the exact inputs that I provided in my previous comment? I can't reproduce any errors with those inputs.

from equivalentcircuits.jl.

i have confirmed that, to the best of my knowledge and someone more knowledgeable than me, that i reinstalled the package and the dependencies properly.

The updates have been included in the GitHub, but not yet in the package registry, I'll have to register a new package version before you'll be able to use them directly through a reinstallation with the package manager.

from equivalentcircuits.jl.

thank you - i will keep trying and see if i can get it to work.

from equivalentcircuits.jl.

I got it to work. I think the problem was that my circuit elements were not uniquely numbered. You renumbered them properly, but I did not realize this was important.

Thanks for your help and attention.

BK

from equivalentcircuits.jl.