Better naming? about hashie_rails HOT 11 CLOSED

We were just discussing this on another mailing list. Maybe hashie-forbidden-attributes even? Suggest more.

from hashie_rails.

How about hashie-strong-parameters? We probably should change dependency to be on strong_parameters gem not on active_support then.

from hashie_rails.

Just tried what @dm1try suggested. Looks like it can work without dependency on activesupport. @dblock do you see any reason to keep activesupport dependency?

from hashie_rails.

@Maxim-Filimonov change dependency to be on strong_parameters is not so good idea, it will be an extra dependency for new projects because "strong parameters" is part of ActiveModel already

so you need some conditional dependency(bundler does not allow those things, I think)

if ActiveModel.VERSION < VersionWithoutStrongParams
  add_runtime_dependency 'strong_params'
...

You can lock on a specific AM version in the future if permitted? interface will be changed to another one(I don't think so :))

BTW, I don't like the way in which Hashie::Mash expand the public interface using any_unexisting_method with suffix ?. In common case your gem solve this problem => hashie-free-permitted?-method 😄 , it will be work not only for strong_params) .

If Mash expand its interface in this way it should allow except option or smth similar..

UPD
Forgot, for me hashie-strong-parameters and hashie-forbidden-attributes are both acceptable.

from hashie_rails.

I merged that PR. @Maxim-Filimonov You should pick a name and go at renaming this!

from hashie_rails.

I've been reading Rubygems guides about naming gems
Looks like as it's extension to Hashie it should be called something like hashie-forbidden_attributes. I'll go with that rename then unless anyone has better idea

from hashie_rails.

👍

from hashie_rails.

from hashie_rails.

Ok renamed.
Haven't pushed to Rubygems yet. If all good with the other one I'll close this issue with deprecation PR

from hashie_rails.

Looks fine to me, made a minor README pr.

from hashie_rails.

https://rubygems.org/gems/hashie-forbidden_attributes 🚀

from hashie_rails.