Comments (3)
again, waiting for word back from github:
Because GitHub Pages builds (sadly) cannot be triggered when authorised just via GITHUB_TOKEN, users of my ghpages action have to provide a separate PAT (issue tracked here: #1).
I understand that stuff done via GITHUB_TOKEN cannot trigger new workflows to be run, which makes a lot of sense.
I worry though, that this might not apply to stuff done via bespoke PATs.In particular, I’m worried that if people deploy via my action to their gh-pages branch, that this very deploy (via PAT!) might trigger the workflew anew, ad infinitum.
This infinite loop is currently unlikely (though possible) because the >1st run will usually error out because there’s no diff to deploy. But it could happen if, e.g. the build artefacts are polluted by the build time or whatever.I currently warn users to always add a filter action before, which can avoid this problem, but I’m not 100% comfortable with this.
This issue is tracked here: #11
What’s your guidance here?
Obviously, I don’t want to be the guy causing infinite loops on github actions.
My (probably nonsensical) suggestion for a solution: Allow GitHub pages builds from events authorised via GITHUB_TOKEN. I can then kill the PAT alltogether and the usual (safe) behavior by which a GITHUB_TOKEN-authorised event couldn’T trigger a workflow anew would be reinstated.
from ghpages.
response from 2019-02-23:
Hi Maximilian,
Thanks for reaching out and asking us about this!
Allow GitHub pages builds from events authorised via GITHUB_TOKEN. I can then kill the PAT
alltogether and the usual (safe) behavior by which a GITHUB_TOKEN-authorised
event couldn’T trigger a workflow anew would be reinstated.This is something other integrators have written in about. We're tracking this internally and I've added your +1 for it so the Actions team is aware.
As far as guidance goes, I don't have any immediate workarounds to offer, though I've raised a separate issue for this asking our engineers for advice! Once I hear more from them, one of us will reach out and share our findings with you.
from ghpages.
and 2019-03-05:
Our team reviewed this and they let me know that they're aware of this challenge at the moment. They agree this experience should be improved, though they don't have any near-term plans to address this. For now, they recommend sticking with the identified workaround (or mitigation) of using the filter action.
Please let us know how else we can be of help!
from ghpages.
Related Issues (20)
- alloy deploy to master branch /docs/
- Does not work with the root directory (BUILD_DIR = /.) HOT 5
- Return neutral code when nothing to commit HOT 1
- run integration test HOT 2
- CNAME file
- maybe merge with other ghpages? HOT 1
- add better name to listing
- release and hard-code git version in documentation
- migrate to a node.js action HOT 4
- document minimum required scope for PAT
- Heartbeat HOT 1
- deployment overwrites my master branch with the build
- Consider creating a `.nojekyll` file
- add new metadata
- migrate to new yaml metadata
- Fatal: Could not read Username for "https://github.com", No such device or address
- add branch deploy
- use GITHUB_TOKEN HOT 1
- GitHub default branch name is main
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghpages.