Git Product home page Git Product logo

Comments (5)

rchurchley avatar rchurchley commented on August 19, 2024

I have tested cc24402 with the default beamer colour themes: albatross, beaver, beetle, crane, default, dolphin, dove, fly, lily, orchid, rose, seagull, seahorse, sidebartab, structure, whale, and wolverine. It works essentially as expected, with the following quirks:

  • Several themes do not define some colours, expecting to inherit them from default; for example, they may intend to have red alerted text as per the default but do not specify this. When used with our theme, these styles will fall back to mtheme's colours instead of the defaults. We may want to provide some option for beamercolorthememetropolis to not set the base colours normal text, alerted text, and example text to allow users to let users revert to the default colour scheme.
  • The \plain{...} command does not work with the fly theme. This is because fly has an annoying definition of palette primary which specifically unsets the background. I don't think there's a non-hacky way of fixing this while maintaining the expected behaviour for the other themes.

from mtheme.

benjamin-weiss avatar benjamin-weiss commented on August 19, 2024

I have tested cc24402 with the default beamer colour themes.

Wow. Sounds like a lot of boring work.

We may want to provide some option for beamercolorthememetropolis

Maybe even go a step further and provide an option not to load the color theme at all. And instead only define the new beamer colors we use?

\if@nocolortheme
  \setbeamercolor{title separator}{use=progress bar, parent=progress bar}
  \setbeamercolor{progress bar}{%
    use=alerted text,
    fg=alerted text.fg,
    bg=normal text.bg!50!fg
  }
\else
  \usecolortheme{metropolis}
\fi

If I get it right, this should also fix the problem and an option like this should be easier to understand than notSetBaseColors.

The \plain{...} command does not work with the fly theme.

It appears to me that this is a bug of the fly theme. I wouldn't really care about that. Lets just keep it in mind and add it to the documentation as a known issue.

from mtheme.

rchurchley avatar rchurchley commented on August 19, 2024

Maybe even go a step further and provide an option not to load the color theme at all. And instead only define the new beamer colors we use?

After splitting the theme into its inner, outer, font, and colour components, it is now possible to take advantage of the structural parts of the theme without loading the colour theme. However, Beamer colors for (e.g.) progress bar are not defined if the color theme is not loaded. Should we provide defaults in the inner and outer themes?

from mtheme.

benjamin-weiss avatar benjamin-weiss commented on August 19, 2024

We should provide defaults, but I don't think the inner and outer themes are the right place for it. Actually we already provide sensible defaults, as our color definitions of the progress bar are dependent on the alerted text and the normal text color. So if someone just loads the mtheme and then a stock color theme, this should work just fine.

So I don't think there is really a need to provide an option to not load the color theme and we can just close this issue.

from mtheme.

rchurchley avatar rchurchley commented on August 19, 2024

That's fine by me.

from mtheme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.