Git Product home page Git Product logo

Comments (3)

matthewwardrop avatar matthewwardrop commented on June 27, 2024

Hi Alex! Thanks for reaching out again.

This is also not a bug, and is documented abstractly here: https://matthewwardrop.github.io/formulaic/guides/grammar/#behaviours-and-conventions
image
The patsy documentation related to this is here: https://patsy.readthedocs.io/en/latest/formulas.html#redundancy-and-categorical-factors.

In short, though, we want to ensure that the matrices generated are (at least structurally) full rank. Since categorical encodings span the intercept, including the full Cartesian product of values would span the intercept column, leading to non-full-rank model matrices. Instead, we give you full set of features that span the requested Cartesian product.

If you omit the intecept, you will see that the Cartesian product is more like you expect.
image

You can also disable this behaviour by passing ensure_full_rank=False to the model_matrix or get_model_matrix functions, for example:
image
At the cost of guaranteeing structurally that the model matrix will not be full rank. In (e.g.) linear regression, this will cause X.T @ X to not be invertible and introduce a gauge degree of freedom in your model.

R is inconsistent with this kind of behaviour. It tries to reduce the rank of categorical variables on their own, but gives up for higher order interactions. We just do it properly.

from formulaic.

s3alfisc avatar s3alfisc commented on June 27, 2024

Ah, ok, this makes perfect sense! Thank you for your swift response =) My incorrect assumption was that formulaic mimics R's model.matrix(), but obviously it is based on patsy. I will have to think through if I want to set ensure_full_rank = False as a default for pyfixest (for perfect compatibility with fixest / R), or if I should keep with the formulaic defaults. Both fixest and pyfixest include a function to detect and drop multicollinear variables, so I (can) in principle ensure that the design matrix is of full rank even after calling formulaic.get_model_matrix(..., ensure_full_rank = False). I should also spend some time to read through the patsy docs!

As a side point, I've worked quite a bit with formulaic in the past week, and I found myself several times thinking that working with formulaic is really quite a pleasant experience! Starting from a already high base, using some of the "more advanced" features of the package has clearly increased my appreciation of your work even further! =)

from formulaic.

matthewwardrop avatar matthewwardrop commented on June 27, 2024

Thanks for the compliment!

It's worth noting, though, that even when you set ensure_full_rank=False it won't match R exactly in all cases... Since R does sometimes try to reduce rank of categorical encodings to maintain full rank... It just isn't as consistent in doing so. There is no option in Formulaic that perfectly matches R's inconsistent behaviour.

from formulaic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.