Require documentation/examples when changing rotation database? about jlckicadtools HOT 5 CLOSED

Ok, I just realised that the footprint from the rule above does not even exist in the current library: https://github.com/KiCad/kicad-footprints/tree/master/Capacitor_Tantalum_SMD.pretty

It should be ^CP_EIA-3216-18_*.

It seems like the problem is not on JLC's end. My original point still stands however.

from jlckicadtools.

JLC changed many of their rotations recently. We changed the database file to match. For example: #22

There are also cases where different pin counts of the same footprint have different rotations: #23

When JLC changes their rotation, there's really not much we can do about that, until someone notices and fixes JLCKicadTools.

With different pin counts, we can either require each pin count to be verified, which means many people will need to add their own entry, even though most will be consistent.

Our current approach to verification is users are supposed to check the orientation of each component on their board on the JLC site before ordering, and (hopefully) submit a pull request to update the database.

Yes, a reference board would be good. Contribution welcomed :).

from jlckicadtools.

Yeah, I have seen those PRs. I appreciate the effort! :)

So far, I've only had one single board where the rotations as provided were good without any tuning. What keeps me from submitting PRs is the lack of confidence that it wouldn't break other parts.

Unless there is a way to demonstrate that my changes are indeed going to improve coverage as a whole, I am going to keep my hacks to myself.

from jlckicadtools.

Yeah, I have seen those PRs. I appreciate the effort! :)

So far, I've only had one single board where the rotations as provided were good without any tuning. What keeps me from submitting PRs is the lack of confidence that it wouldn't break other parts.

Unless there is a way to demonstrate that my changes are indeed going to improve coverage as a whole, I am going to keep my hacks to myself.

Sure, that is up to you. I don't think any of us are offering any guarantees, and all changes are on a best effort basis. We do still want people to visually check every board before ordering, because JLC changes their rotations, if nothing else.

You can also just submit rotations for specific footprints, if you don't want it to be applied to other variants of the footprint.

JLC (at least for now) is also having a human look at every order, and change rotations where they are obviously wrong. When I contacted them, their advice is to "just order" if in doubt, and their engineer will verify/change, and contact you if the correct orientation is not obvious from silkscreen.

from jlckicadtools.

Ok, at least for the tantalum cap in question I am confident I identified the problem 👍

See PR #27 .

from jlckicadtools.