Comments (14)
matthew-matvei
commented on May 31, 2024
Could you give any further details? Namely:
- Are you building the latest version of
developormasterbranch? - Which operating system are you using?
- What version of
npmare you using?
from freeman.
SolarAquarion
commented on May 31, 2024
- freemen
- Arch Linux
- 6.1.0
from freeman.
matthew-matvei
commented on May 31, 2024
- There is no branch named
freemen
Hmm, I've only had troubles building dependencies on Windows. On Linux, the node-pty dependency is a lot more reliable to build in my opinion.
I'll try a fresh clone and build of the latest version of develop when I'm home (access to a Linux box), and hopefully I'll be able to reproduce this.
from freeman.
matthew-matvei
commented on May 31, 2024
Wasn't able to recreate this on Elementary OS, using the latest version of develop and npm at version 6.1.0. In any case, it seems your problem is with building the node-pty dependency.
I suggest taking this error to either the node-pty or the electron-builder (which is run as a postinstall script) project to see if they can be more helpful.
from freeman.
SolarAquarion
commented on May 31, 2024
It fails in the install path of npm for me
…On Tue, Jun 12, 2018, 3:04 PM Matthew James ***@***.***> wrote:
@SolarAquarion <https://github.com/SolarAquarion>
Wasn't able to recreate this on Elementary OS, using the latest version of
develop and npm at version 6.1.0. In any case, it seems your problem is
with building the node-pty dependency.
I suggest taking this error to either the node-pty or the electron-builder
or electron-builder (which is run as a postinstall script) to see if they
can be more helpful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFD6iLLpqni7JnElKEhi1TuwrCtVuDC8ks5t8BDQgaJpZM4Uh4Z6>
.
from freeman.
jblaszczyk
commented on May 31, 2024
I got the same error with node.js v10.5.0 both on master and develop branches while building on ubuntu. node-pty issue disappeared with node.js v8.11.3 and built properly.
from freeman.
matthew-matvei
commented on May 31, 2024
@jblaszczyk Thanks!
@SolarAquarion Could you confirm whether rolling back your version of NodeJS works for you by building latest of develop using v8.11.3 of Node?
from freeman.
SolarAquarion
commented on May 31, 2024
$ webpack-cli --config webpack.common.js
ℹ ｢atl｣: Using [email protected] from typescript
ℹ ｢atl｣: Using tsconfig.json from /home/solaraquarion/freeman/tsconfig.json
ℹ ｢atl｣: Using [email protected] from typescript
ℹ ｢atl｣: Using tsconfig.json from /home/solaraquarion/freeman/tsconfig.json
ℹ ｢atl｣: Checking started in a separate process...
✖ ｢atl｣: Checking finished with 4 errors
ℹ ｢atl｣: Checking started in a separate process...
✖ ｢atl｣: Checking finished with 4 errors
Hash: 6bb6aef657e02899da3bdc9ee21ccc4b66dc6f23
Version: webpack 4.12.2
Child
Hash: 6bb6aef657e02899da3b
Time: 10173ms
Built at: 06/27/2018 10:42:34 AM
Asset Size Chunks Chunk Names
main.js 38.3 KiB main [emitted] main
[./src/common/Utils.ts] 1.18 KiB {main} [built]
[./src/main/arguments/ArgumentsParser.ts] 559 bytes {main} [built]
[./src/main/arguments/index.ts] 77 bytes {main} [built]
[./src/main/index.ts] 2.16 KiB {main} [built]
[./src/main/widgets/FreemanWindow.ts] 1.33 KiB {main} [built]
[./src/main/widgets/index.ts] 71 bytes {main} [built]
[electron] external "electron" 42 bytes {main} [built]
[electron-debug] external "electron-debug" 42 bytes {main} [built]
[electron-log] external "electron-log" 42 bytes {main} [built]
[electron-window-state] external "electron-window-state" 42 bytes {main} [built]
[fuzzysearch] external "fuzzysearch" 42 bytes {main} [built]
[immutable] external "immutable" 42 bytes {main} [built]
[path] external "path" 42 bytes {main} [built]
[react-dom] external "react-dom" 42 bytes {main} [built]
[reflect-metadata] external "reflect-metadata" 42 bytes {main} [built]
+ 1 hidden module
ERROR in [at-loader] ./src/renderer/objects/Shell.ts:3:39
TS7016: Could not find a declaration file for module 'node-pty/lib/interfaces'. '/home/solaraquarion/freeman/node_modules/node-pty/lib/interfaces.js' implicitly has an 'any' type.
Try `npm install @types/node-pty` if it exists or add a new declaration (.d.ts) file containing `declare module 'node-pty';`
ERROR in [at-loader] ./src/renderer/objects/Shell.ts:43:33
TS7006: Parameter 'data' implicitly has an 'any' type.
ERROR in [at-loader] ./src/renderer/components/modals/Goto.tsx:89:23
TS2322: Type '{ color: string | boolean; }' is not assignable to type 'CSSProperties'.
Types of property 'color' are incompatible.
Type 'string | boolean' is not assignable to type 'string | undefined'.
Type 'true' is not assignable to type 'string | undefined'.
ERROR in [at-loader] ./src/renderer/components/blocks/DirectoryItem.tsx:107:15
TS2322: Type '{ color: string | boolean; width: string; }' is not assignable to type 'CSSProperties'.
Types of property 'color' are incompatible.
Type 'string | boolean' is not assignable to type 'string | undefined'.
Type 'true' is not assignable to type 'string | undefined'.
Child
Hash: dc9ee21ccc4b66dc6f23
Time: 12497ms
Built at: 06/27/2018 10:42:36 AM
Asset Size Chunks Chunk Names
e19892df121e7f85c61754c54bbb7951.woff2 48.6 KiB [emitted]
11d1a2390613abf202bfd2ebbd5c4500.woff2 88.6 KiB [emitted]
af7ae505a9eed503f8b8e6982036873e.woff2 75.4 KiB [emitted]
0a32a80243e05284a5d741c5dc093f31.woff2 23.8 KiB [emitted]
de59a97248b44599e6747a27a943f738.woff2 19.8 KiB [emitted]
c1777245327bec775fbf955c24b98bc1.woff2 33.2 KiB [emitted]
9937c52ecf1224033b83886cbfb10ae6.woff2 26.3 KiB [emitted]
renderer.js 413 KiB renderer [emitted] renderer
renderer.css 72.3 KiB renderer [emitted] renderer
[./src/common/Utils.ts] 1.18 KiB {renderer} [built]
[./src/common/ioc/container.ts] 848 bytes {renderer} [built]
[./src/common/ioc/types.ts] 438 bytes {renderer} [built]
[./src/renderer/index.tsx] 1.8 KiB {renderer} [built]
[./src/renderer/objects/Persister.ts] 544 bytes {renderer} [built]
[./src/renderer/objects/index.ts] 470 bytes {renderer} [built]
[electron] external "electron" 42 bytes {renderer} [built]
[electron-devtools-installer] external "electron-devtools-installer" 42 bytes {renderer} [built]
[electron-log] external "electron-log" 42 bytes {renderer} [built]
[fuzzysearch] external "fuzzysearch" 42 bytes {renderer} [built]
[immutable] external "immutable" 42 bytes {renderer} [built]
[path] external "path" 42 bytes {renderer} [built]
[react] external "react" 42 bytes {renderer} [built]
[react-dom] external "react-dom" 42 bytes {renderer} [built]
[reflect-metadata] external "reflect-metadata" 42 bytes {renderer} [built]
+ 90 hidden modules
ERROR in [at-loader] ./src/renderer/objects/Shell.ts:3:39
TS7016: Could not find a declaration file for module 'node-pty/lib/interfaces'. '/home/solaraquarion/freeman/node_modules/node-pty/lib/interfaces.js' implicitly has an 'any' type.
Try `npm install @types/node-pty` if it exists or add a new declaration (.d.ts) file containing `declare module 'node-pty';`
ERROR in [at-loader] ./src/renderer/objects/Shell.ts:43:33
TS7006: Parameter 'data' implicitly has an 'any' type.
ERROR in [at-loader] ./src/renderer/components/modals/Goto.tsx:89:23
TS2322: Type '{ color: string | boolean; }' is not assignable to type 'CSSProperties'.
Types of property 'color' are incompatible.
Type 'string | boolean' is not assignable to type 'string | undefined'.
Type 'true' is not assignable to type 'string | undefined'.
ERROR in [at-loader] ./src/renderer/components/blocks/DirectoryItem.tsx:107:15
TS2322: Type '{ color: string | boolean; width: string; }' is not assignable to type 'CSSProperties'.
Types of property 'color' are incompatible.
Type 'string | boolean' is not assignable to type 'string | undefined'.
Type 'true' is not assignable to type 'string | undefined'.
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/App.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/App.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/App.scss 497 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/blocks/DirectoryItem.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/blocks/DirectoryItem.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/blocks/DirectoryItem.scss 405 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/blocks/DirectoryItemIcon.scss:
5 assets
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/blocks/DirectoryItemIcon.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/blocks/DirectoryItemIcon.scss 289 bytes {0} [built]
+ 8 hidden modules
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/blocks/InputItem.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/blocks/InputItem.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/blocks/InputItem.scss 271 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/main.scss:
2 assets
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/main.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/main.scss 3.08 KiB {0} [built]
[./src/renderer/styles/font/Ubuntu-Regular.woff2] 84 bytes {0} [built]
[./src/renderer/styles/font/UbuntuMono-Regular.woff2] 84 bytes {0} [built]
+ 2 hidden modules
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/panels/DirectoryHeader.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/DirectoryHeader.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/DirectoryHeader.scss 297 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/panels/DirectoryList.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/DirectoryList.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/DirectoryList.scss 221 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/panels/PathPanel.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/PathPanel.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/PathPanel.scss 253 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/panels/QuickSelect.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/QuickSelect.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/QuickSelect.scss 202 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/panels/Status.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/Status.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/Status.scss 407 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/panels/TerminalHeader.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/TerminalHeader.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/TerminalHeader.scss 239 bytes {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/panels/TerminalPane.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/TerminalPane.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/panels/TerminalPane.scss 615 bytes {0} [built]
+ 2 hidden modules
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/wrappers/DirectoryWrapper.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/wrappers/DirectoryWrapper.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/wrappers/DirectoryWrapper.scss 1.04 KiB {0} [built]
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-1!node_modules/sass-loader/lib/loader.js??ref--6-2!src/renderer/styles/wrappers/TerminalWrapper.scss:
[./node_modules/css-loader/index.js??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/wrappers/TerminalWrapper.scss] ./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js??ref--6-2!./src/renderer/styles/wrappers/TerminalWrapper.scss 333 bytes {0} [built]
+ 1 hidden module
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
yarn run build 17.00s user 0.48s system 133% cpu 13.103 total
solaraquarion@apollo ~/freeman f9f239c2f3441192ec8c develop npm install @types/node-pty
npm ERR! code E404
npm ERR! 404 Not Found: @types/node-pty@latest
from freeman.
SolarAquarion
commented on May 31, 2024
It builds with 8.11.3
from freeman.
matthew-matvei
commented on May 31, 2024
@SolarAquarion A bit disappointing node-pty doesn't build on a more recent version of Node. If you can recreate this outside the context of Freeman (in a small project for the purposes of reproducing the issue), I'd go to node-pty with it.
I'm closing this as this seems to be an issue with building a dependency more recent versions of Node.
from freeman.
SolarAquarion
commented on May 31, 2024
See my yarn log, there may be something you can do
…On Wed, Jun 27, 2018, 3:32 PM Matthew James ***@***.***> wrote:
@SolarAquarion <https://github.com/SolarAquarion> A bit disappointing
node-pty doesn't build on a more recent version of Node. If you can
recreate this outside the context of Freeman (in a small project for the
purposes of reproducing the issue), I'd go to node-pty
<https://github.com/Microsoft/node-pty> with it.
I'm closing this as this seems to be an issue with building a dependency
more recent versions of Node.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFD6iOtLz8ZOxYL_NUtBglCG_GNdTDprks5uA93ogaJpZM4Uh4Z6>
.
from freeman.
matthew-matvei
commented on May 31, 2024
Your yarn log seems to describe a separate issue now with the types related
to the node-pty package.
If you feel it's something specifically related to Freeman and not the
dependency, please describe why.
Given that this other error you're receiving indicates a different problem,
if you still believe this is a problem in Freeman and not in the
dependency, please open a separate issue about it.
On Wed, 27 Jun 2018, 20:55 SolarAquarion, ***@***.***> wrote:
See my yarn log, there may be something you can do
On Wed, Jun 27, 2018, 3:32 PM Matthew James ***@***.***>
wrote:
> @SolarAquarion <https://github.com/SolarAquarion> A bit disappointing
> node-pty doesn't build on a more recent version of Node. If you can
> recreate this outside the context of Freeman (in a small project for the
> purposes of reproducing the issue), I'd go to node-pty
> <https://github.com/Microsoft/node-pty> with it.
>
> I'm closing this as this seems to be an issue with building a dependency
> more recent versions of Node.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#23 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AFD6iOtLz8ZOxYL_NUtBglCG_GNdTDprks5uA93ogaJpZM4Uh4Z6
>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASYrR_5SPkhdVZDzXcDA30fx-mwbf8Mvks5uA-MsgaJpZM4Uh4Z6>
.
--
Matthew James
Mob: 0478 571 825
UQ: [email protected]
from freeman.
SolarAquarion
commented on May 31, 2024
https://github.com/daviwil/node-pty-prebuilt
this seems interesting
from freeman.
matthew-matvei
commented on May 31, 2024
@SolarAquarion If you think it would improve the app, please create a PR that aims to close this issue (if I see the PR created, I'll reopen this issue.
My main concern would be bringing in a dependency that is a fork of a fork (with node-pty being a fork of pty), but we could give the prebuilt fork a go and jump ship if it falls behind significantly.
from freeman.
Related Issues (20)
- Sync terminal navigation with directory pane
- Cannot find module '..\build\Release\pty.node' HOT 2
- Preserve window and pane dimensions
- Provide methods for displaying the FreeMAN version
- Rectify Code Climate score HOT 1
- Use fs.access to determine if directory can be accessed
- Add 'Created on' column
- Chosen shell config setting not respected HOT 1
- Implement toaster for warning messages
- Nothing showing on Windows 10 HOT 7
- Activate developer tools only in development
- Open integrated terminal in same place as directory list
- Make folder to open directory lists and terminals configurable
- Persist open folders across sessions
- Cannot cancel renaming item
- Persist column widths across sessions
- Upgrade electron-builder to >=20.14.7
- Can't npm install HOT 1
- How to use
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freeman.