4xx responses do not return the response body about mgtwitterengine HOT 4 OPEN

At the very least, I think that the HTTP headers should be made available. http://apiwiki.twitter.com/Rate-limiting

Then it would be possible to look at the rate-limiting headers in the response and provide more accurate feedback as to when rate-limits should be reset, for example.

from mgtwitterengine.

I've forked and have a local topic branch that I'm working up patches for this issue.

1. Passing the HTTP headers through it pretty straightforward; not too invasive a change.
2. Making the response body available to the requestFailed:withError: delegate call is a little bit more work.

For the second case, I'm thinking along these lines:

• Adding a NSHTTPURLResponse field to MGTwitterURLConnection
• Setting that field in the connection:didReceiveResponse: implementation. Only 304 Not Modified logic would be retained there.
• Moving the part of connection:didReceiveResponse: that deals with 4xx status codes into connection:didFinish and using that as a guard condition above the existing code, before it invokes requestSucceeded: on the delegate.

Does that sound reasonable and would the changes be welcomed?

from mgtwitterengine.

Topic branch available here - http://github.com/jabley/MGTwitterEngine/tree/39-error-response-body

from mgtwitterengine.

Ping

http://github.com/jabley/MGTwitterEngine/compare/mattgemmell:master...39-error-response-body

from mgtwitterengine.