Comments (7)
OK, I'll have a look.
PS. Thanks for the excellent bug report 👍
from swashbuckle.aspnetcore.filters.
Released https://www.nuget.org/packages/Swashbuckle.AspNetCore.Filters/4.0.2
from swashbuckle.aspnetcore.filters.
Hehe. Thanks for spotting the bug. If you find any more bugs then please open a new issue.
Fix released in https://www.nuget.org/packages/Swashbuckle.AspNetCore.Filters/4.0.3
from swashbuckle.aspnetcore.filters.
Thanks :D
from swashbuckle.aspnetcore.filters.
Hello,
It's me again sorry :)
I can still reproduce the same issue, but this time with a generic list : IEnumerable<SubModelB>
and ICollection<SubModelB>
.
It looks like a similar issue, isn't it?
from swashbuckle.aspnetcore.filters.
Are you sure? I just tried with
public class RootModel
{
[Description("This ROOT description works")]
public SubModelA SubModelA { get; set; }
[Description("This ROOT description works")]
public ICollection<SubModelB> subModelBs { get; set; }
}
and IEnumerable<SubModelB>
, and both work fine.
from swashbuckle.aspnetcore.filters.
Hey,
After more investigation, yes, there is an issue, but not as described.
In fact, the description in SubModelB
is not rendered if there is no Description on the list property in the RootModel
.
Try to comment/uncomment
the Description attribute on subModelBs
to see the difference :
[Route("api/[controller]")]
public class ValuesController : Controller
{
[HttpPost]
[SwaggerResponse((int)HttpStatusCode.OK, Type = typeof(RootModel))]
public IActionResult Post()
{
return Ok();
}
}
public class RootModel
{
//[Description("This description works")]
public ICollection<SubModelB> subModelBs { get; set; }
}
public class SubModelB
{
[Description("This description DOESN'T work if the description in RootModel is commented")]
public string B { get; set; }
}
Maybe you would prefer I open a different issue for this? :)
from swashbuckle.aspnetcore.filters.
Related Issues (20)
- Can't generate multiple response examples for Task<IAction> controller method HOT 2
- Provide string[] via param different than on a property (improve documentation) HOT 3
- Bump version of dependency Swashbuckle.AspNetCore.SwaggerGen to be compatible with recent Swashbuckle versions HOT 4
- Multiple responses not showing in Swagger UI
- SwaggerRequestExample does not generate examples HOT 1
- Add support for OpenAPI SpecificationExtensions to the SwaggerExample.Create method HOT 5
- FormatterNotFoundException for text/csv upgrading to 7.0.6 HOT 10
- SecurityRequirementsOperationFilter<T> looks for attributes in the method DeclaringType instead of ReflectedType HOT 1
- SecurityRequirementsOperationFilter doesnt work with MinimalAPIs HOT 6
- Swashbuckle.AspNetCore.Filters.Abstractions (>= 7.0.7) not published HOT 3
- Using Registered Services in HttpContext that is Used During Example Generation HOT 6
- Unoptimized assembly detected: 'Swashbuckle.AspNetCore.Filters.dll' HOT 2
- IAsyncEnumerable serializer HOT 3
- Is Swashbuckle.AspNetCore.Examples still required to be used together with Filters package? HOT 2
- Generating examples for abstract request type HOT 4
- Minimal Api returns examples in Pascal case with no option to change HOT 3
- swagger started to throw exception that there is no xml output formatter, which I don't need, but after adding it all responses become in xml HOT 4
- How to properly wire up generic versions of AppendAuthorizeToSummaryOperationFilter<T> and SecurityRequirementsOperationFilter<T>? HOT 1
- SwaggerResponseExample override example xml comments irrelevant to status code HOT 8
- example tag for swagger will not be display in my project if the request class is located in another project or class library HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swashbuckle.aspnetcore.filters.