Add clearer warning when failing to resolve seedNodes via DNS about polykey HOT 6 OPEN

@aryanjassal when you feel more comfortable with the source code this might be a good issue to start with.

from polykey.

ENG-350 Add clearer warning when failing to resolve seedNodes via DNS

from polykey.

I want to clarify the requirements of this issue.

For the first task, I need to include additional details, like a custom error message stating that DNS resolution failed, correct?

For the second task, success of this function would happen just before the return statement in the function, right? If that is the case, then I just have to send a message stating that node resolution using DNS succeeded, right?

I'm also not sure how to approach the task of using nodeGraph entries as fallback seednode list if resolving fails.

from polykey.

1. Right now when resolving DNS fails, it just returns no results. From the outside this looks like a failure to sync the node graph. But there is few ways that can fail with DNS being one of them. So the message No seednodes could be found for for mainnet.polykey.com is too vague here. It needs to be clear that we failed to resolve them by DNS with a descriptive message. Just to distinguish it from say, failing to connect to any seed nodes.
2. Yes, so inside resolveSeednodes function we need to call logger.info with a message stating that resolving the seed nodes succeeded with some details about it. But it's a utility function and we don't usually pass a logger into it. So the info message will likely need to be done where resolveSeednodes is called.
3. If DNS resolution fails then we don't end up with a list of addresses to connect to. Check the node graph for either records relating to the nodes we wanted to resolve in the first place. Or get a list of nodes to use instead of seed nodes. I don't know if the node graph tracks if a node had a public IP but if it does then prefer those.

Don't get too stuck into this if you're struggling. The main goal is to get a top level overview of Polykey's structure for now. It will take too long to get intimate knowledge of all it's parts for now.

from polykey.

Related to #729?

from polykey.

Yeah, this is related but on top of the warning this issue wants to add using the NodeGraph as a fallback for entering the network f we fail to resolve the seed nodes.

from polykey.