MXIDs with slashes (`/`) incorrectly rejected about matrix.to HOT 8 OPEN

Maintainer of Cactus Comments here.
I was just made aware of this bug in matrix.to because a friend of mine has broken links on their blog because of it as well.
It seems to still be an issue.

from matrix.to.

this probably happens because the parser does split the fragment (except the common prefix) by / (for the event id) before checking where the local part ends:

from matrix.to.

this issue made me stop using https://cactus.chat/ in my static website and will instead use https://giscus.app/

from matrix.to.

We have likely the same issue:

If I "copy the room link" in Element Desktop (or Web too BTW), https://matrix.to/#/#aboutcode-org/fosdem-2024:gitter.im is the link copied

But this is a dead, invalid link. It should have been
https://app.gitter.im/#/room/#aboutcode-org/fosdem-2024:gitter.im

matrix.to does not redirect correctly rooms with a slash.

from matrix.to.

I am experiencing the same issue and I originally thought this was an Element problem. element-hq/element-desktop#1435 ... this makes life really difficult as the generated matrix.to links are useless and error out. So you cannot really share you room at all.

from matrix.to.

as @Zocker1999NET pointed out the split is the issue. Here is a simple excerpt:

function parseFragment(fragment) {
        let [linkStr, queryParamsStr] = fragment.split("?");
        linkStr = linkStr.slice(2);
        const [identifier, eventId] = linkStr.split("/");
        return {"identifier": identifier, "eventId": eventId};
    }
parseFragment("/#aboutcode-org/vulnerablecode:gitter.im")

returns:

Object { identifier: "aboutcode-org", eventId: "vulnerablecode:gitter.im" }

But should have returned:

Object { identifier: "aboutcode-org/vulnerablecode:gitter.im", eventId: "" }

Also I could not find a tests for this function... are they in another repository may be? 😇

from matrix.to.

Neither unescaped (https://matrix.to/#/@it/sme:matrix.org) nor escaped (https://matrix.to/#/@it%2Fsme:matrix.org) links does not work.

from matrix.to.

Also the error message is misleading because the URL is actually valid

> new URL('https://matrix.to/#/@it/sme:matrix.org')
> URL {
hash: "#/@it/sme:matrix.org"
host: "matrix.to"
hostname: "matrix.to"
href: "https://matrix.to/#/@it/sme:matrix.org"
origin: "https://matrix.to/"
password: ""
pathname: "/"
port: ""
protocol: "https:"
search: ""
searchParams: URLSearchParams(0)
username: ""
}

from matrix.to.