Move params from heimdall-config to genesis file about heimdall HOT 8 CLOSED

Interesting. But, in our current approach, we can change the bor-chain-ids as multiple ids without creating a new Heimdall chain.

from heimdall.

Agreed. New chain is' will be added via a transaction to the heimdall state. So this param should exist in the state. We cannot expect people to add one more chain id in their config and restart node.

from heimdall.

Agreed.

from heimdall.

numberOfConfirmations should be in heimdall config, no?

from heimdall.

Since number of confirmations decides if a tx is valid or not it should be in the genesis file.

from heimdall.

Number of confirmations will change only when the whole network decides to.

from heimdall.

@ptsayli check branch chain-manager

from heimdall.

implemented in #273

from heimdall.