Move Numerics.IO to separate NuGet package to get rid of zlib.net dependency about mathnet-numerics HOT 8 CLOSED

It would be nice to remove the zlib dependency completely. I noticed that .NET 4.5 now uses zlib for DeflateStream and I wonder if we could now just use that (though that changes the runtime requirements). Another option is to use the .NET 4.0 version of DeflateStream and handle the header and checksum manually. See http://tlzprgmr.wordpress.com/2010/03/17/net-deflatestreamzlib-compatibility/ .

from mathnet-numerics.

I implemented the later in my zlib branch. It seems to work (tests pass and matlab can open a generated file).

Could someone else give it a spin?

from mathnet-numerics.

That would simplify things indeed.
Unfortunately I no longer have a matlab license around myself.

Concerning your note in MatlabWriter.CompressData:
Have you tried setting leaveOpen=true in the deflate stream ctor?

from mathnet-numerics.

leaveOpen=true
That did it. Thanks!

from mathnet-numerics.

Great! Looking forward to pull it in.

from mathnet-numerics.

After a little more testing, I think it works. The tests also uncovered a bug in how we were parsing sparse matrices. That is also fixed. Sending a pull request.

from mathnet-numerics.

I think this can be closed now, as there isn't a dependency to zlib.net any more.

from mathnet-numerics.

Yes - thank your both for the patches! We may still want to create a separate package later on since we may need to introduce other dependencies there for other formats, but we can delay it until then or the next major release.

from mathnet-numerics.