Comments (2)
OK, I can confirm that the default constructor for the Volume class is indeed initializing to non-one, so this bug is purely in the output and not in the actual simulation.
from physicell.
OK, so Cell::Cell needs to call set_total_volume( phenotype.volume.total ) so that BioFVM knows the total volume. BioFVM saves basic cell information (including volumes) that are read by all our read routines. Since the BioFVM information had not yet been updated, the BioFVM defaults of 1 cubic micron are written to the initial data.
Before the fix, this gets called after the first volume update, explaining why the volumes were fine at the next save time.
Now, Cell::Cell() and the create_cells() functions properly call this functoin so that all cells get teh right volume at their time of creation.
This issue is now fixed and slated for release in 1.7.0 in mid March. Thank you for the bug report!
In the future, please note that the preferred support tracker is at SourceForge:
https://sourceforge.net/p/physicell/tickets/
from physicell.
Related Issues (20)
- make reset - avoid "rm *.cpp"? HOT 6
- DC function standardization HOT 1
- Passing in files and folders as command line arguments
- Improvement: lineage tree information in default output HOT 1
- Improvement: Makefile save command automatically adjusts PROJ := my_project HOT 1
- Clarifying attack/damage rates HOT 2
- saving rules v1 instead of v2 to /output HOT 3
- Command "make" errors out on windows HOT 5
- MultiCellDS saves `elapsed_time_in_phase` twice?
- hard-coded buffer size can crash saving output for large models
- Fails to build with NVHPC 24.5 HOT 2
- spaces for tab
- cells.csv and cell_rules.csv in output folder
- sample_projects_intracellular ode and fba Makefile are incomplete
- sample_projects_intracellular/fba/cancer_metabolism has two Makefiles one for windows one for unix
- PhysiCell_settings-backup.xml concept is broken HOT 1
- PhysiCell::Cell_Definition possibly memory leaking HOT 1
- disconnect between Studio and C++ for custom cell functions, etc. HOT 1
- custom cell division; cell lineage HOT 6
- Enhancement: MCDS output.xml label carries additional information about the column data type HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from physicell.