Git Product home page Git Product logo

Comments (6)

chc273 avatar chc273 commented on June 18, 2024

@araquejc for historic reasons, the QM9 models were built by using atom types, so the model will first convert the atomic number to the corresponding type before passing it to the model.

class AtomNumberToTypeConverter(MSONable):

from megnet.

chc273 avatar chc273 commented on June 18, 2024

@araquejc To be precise, our original qm9 models were initially trained on the processed qm9 dataset by Faber et. al. J. Chem. Theory Comput. 2017, 13, 11, 5255–5264, where they have atom types (integer) instead of atomic number. In later model developments, we decided to use the atomic number for graph construction, so we had to make this conversion to be compatible.

from megnet.

araquejc avatar araquejc commented on June 18, 2024

@chc273 Thanks for your quick reply!

Does that mean that in the code above embedding[1] == "H", embedding[2] == "C", embedding[4] == "N", embedding[6] == "O" and embedding[8] == "F"?

from megnet.

chc273 avatar chc273 commented on June 18, 2024

Yes you are right @araquejc

from megnet.

araquejc avatar araquejc commented on June 18, 2024

Thanks again! That was my initial guess, but I wanted to cross check with you. I think it is useful to know this before trying transfer learning for MEGNet models reading pymatgen molecules directly (i.e., using atomic number).

from megnet.

araquejc avatar araquejc commented on June 18, 2024

BTW, you are welcome to close the issue.

from megnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.