Comments (4)
Stunkymonkey
commented on June 12, 2024
why is this not implemented with ExtensionContext.globalState/ExtensionContext.globalStorageUri? Feels for me like the perfect fit.
from vsc-material-theme.
Stunkymonkey
commented on June 12, 2024
@equinusocio we could replace https://github.com/material-theme/vsc-material-theme/blob/main/src/core/extension-manager.ts#L47
posix.join(extensionFolderUri.path, USER_CONFIG_FILE_NAME)with
posix.join(ExtensionContext.globalStorageUri.fsPath, USER_CONFIG_FILE_NAME)But I think this would be a breaking change. see: #1295
from vsc-material-theme.
equinusocio
commented on June 12, 2024
Should not be a breaking change if we write/read the user config from the same place, so in the PR make sure to apply the change in every place we write or read it.
This is an internal mechanic that keeps user settings like theme accent and last installed version.
I can't help so much because I'm not the author of that code and ts is not really my thing. The whole code ts code is not maintained.
from vsc-material-theme.
Stunkymonkey
commented on June 12, 2024
@equinusocio I guess the PR already covers all places, where we read and write, because that is the only place USER_CONFIG_FILE_NAME is used.
from vsc-material-theme.
Related Issues (20)
- Change button text color question HOT 1
- Comments have reduced contrast using the High Contrast Darker theme HOT 1
- Feature Request: Forest Theme Variant HOT 2
- Accent colour does not change (VSCodium) HOT 2
- Issue with macro bracket color inconsistency HOT 1
- Selecting Deep Forest High Contrast theme does nothing HOT 2
- After vscode 1.80 version,The parameter hint has changed from the original gray to the same white as the code font HOT 6
- Command pallet colors are difficult to see HOT 5
- Clarification about APACHE 2.0 license HOT 3
- Deprecated Community Material Theme inside Material Theme? HOT 4
- Parameters inside of functions are red for a quater of a second then white. HOT 6
- Publish Material Theme as a standalone extension HOT 2
- Ability to turn off italic styling
- Add color for const variables HOT 2
- Observations between community and official HOT 2
- Token color customizations do not work properly HOT 6
- Syntax coloration highlighting lost HOT 3
- Add Go format string coloring HOT 3
- Highlight component classes with different colors, like in the legacy Community version of this theme HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vsc-material-theme.