Comments (7)
Yeah lots of people asked about this. It's just how line-height works on the web. The text is supposed to be sitting right in the middle of the baseline grid lines.
That can be done on the web, I've seen it already, but it gets tricky when you allow users to be able to change the font and line-height and it could get messed up really quickly.
from gutenberg.
I thought the idea of a baseline grid is to have text sit on the baseline --> see this screenshot. Do you see the difference between the two screenshots?
from gutenberg.
Hey @mihaisavezi I'm sorry but I don't see what the problem is... everything seems aligned on the screenshot... Gutenberg uses 0.5 line-height (or leading) for some measurements like margins and how many "line-heights" a heading takes. It can be 1.5, that's why we have this double grid, so you can still see if it fits.
from gutenberg.
I have to agree with @mihaisavezi it looks like a bug. I refer to this article: https://medium.com/written-in-code/aligning-type-to-baseline-the-right-way-using-sass-e258fce47a9b#.i6vsda3o8 as a great, yet simple, explanation of a baseline grid for web type.
from gutenberg.
hey @matejlatin even when looking at the gutenberg website and assuming that everything should be in the middle of the line, it looks like there are some missalignments
from gutenberg.
@mswiszcz no it's still correct actually, you need to enable the "double grid". Then those lines will also align. I tend to use the double grid so it gives more flexibility in assigning line heights and font sizes.
from gutenberg.
The paragraph at the very top and the one below the first headline are aligned differently, is that expected? Same with 1st and 2nd headlines. It's a bit confusing, not an expert on typo though
from gutenberg.
Related Issues (20)
- fill out documentation HOT 1
- figure and paragraph indent conflict? HOT 17
- Grunt ignores scss files in folders in src/style HOT 6
- Switch to node-sass HOT 2
- Getting more done in GitHub with ZenHub
- no second-order grid HOT 6
- Override variables in horizontal-rule.scss HOT 1
- Gutenberg doesn't play nice with other styles/libs HOT 8
- How to change font-size in Sass code? HOT 1
- How to customize font-size in media queries?
- Why there's 2 font-sizes for headings?
- Consider typographic baseline
- <em> <i> excessive property HOT 3
- Is the project still alive? HOT 2
- Why is double grid needed? HOT 1
- Remove external font dependencies HOT 2
- License question
- Some vars not used
- Hardcoded image url in helpers/grid
- Deprecation warning: Need to wrap division in `calc()`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg.