Git Product home page Git Product logo

Comments (6)

Gargron avatar Gargron commented on June 18, 2024

Has this been fixed and I forgot to tag the issue, did the browser fix its implementation, or what is the reason for closing this issue?

from joinmastodon.

trwnh avatar trwnh commented on June 18, 2024

Not sure -- if you changed it from multicol to flexbox, then you fixed it and forgot. At least that's what I assumed happened.

from joinmastodon.

trwnh avatar trwnh commented on June 18, 2024

Reopening because it looks even more broken on mobile https://imgur.com/a/TNjhKvr

Chrome 68 on an Xperia X Compact (viewport 424x625)

from joinmastodon.

trwnh avatar trwnh commented on June 18, 2024

mobile landscape 625px
mobile portrait 424px

from joinmastodon.

trwnh avatar trwnh commented on June 18, 2024

Ideally, .sponsorship .sponsors-list--badges li shouldn't have a width off 33.3%; it should be a static px or em width because the information inside the li should not be proportional. For example, Mark Atwood's url is the widest element inside the li: it requires an li width of 256px to look correct.

Also, the ul should probably justify-content to the center in order to account for the growing/shrinking of the ul width.

from joinmastodon.

trwnh avatar trwnh commented on June 18, 2024

Somewhat unrelated issue that is also caused by viewport width: long names in the regular Sponsors list causes the row heights to become out-of-sync.
image

The breakpoint for the Sponsors list (and also in general) should be at the point when it becomes possible to comfortably fit two of the longest elements side-by-side. This means that, to solve the issue with minimal styling changes,

  • the Sponsors should shift from 1 to 2 columns at min-width: 522px and from 2 to 3 columns at min-width: 762px.
  • the Silver Sponsors should be given fixed widths of ~256px and justify-content to the center of their flex container, since the 3-column layout only works at min-width: 777px.

from joinmastodon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.