Comments (4)
Thanks for the patch!
When there's an error parsing the command-line arguments, distcc should return
EXIT_BAD_ARGUMENTS, i.e. 101, rather than 1 or 2.
You updated the copyright date, but in the line that said "Copyright ... by
Martin
Pool". That doesn't seem right. Either leave the copyright messages alone, or
add a
new one with your name. (For a simple change like this, I suggest leaving the
copyright messages unchanged, but I don't mind either way.)
Thanks for the detailed description in the ChangeLog; such change descriptions
help
to make reviewing the change easier and for understanding things later.
However, the
ChangeLog file is now semi-automatically generated from the svn logs at each
release,
rather than being manually maintained at each submit. So it's sufficient to
just
include the description in the svn log message at commit time, rather than
patching
the ChangeLog.
Otherwise, this looks great. Do you want to apply it (submit the change to
svn), or
shall I?
P.S. I've modified the patch to address the minor concerns mentioned above. See
attached.
Original comment by [email protected]
on 8 Jan 2009 at 8:41
- Changed state: Started
- Added labels: Type-Patch
Attachments:
from distcc.
Hi Fergus,
I did not know I could directly submit my changes via svn. I checked out
again following the instructions in the "Source" tab, but found nothing
about "submitting" a change, so I went ahead and applied the patch you
sent me. Is that what I'm supposed to do? The instructions for the
developpers on the wiki are a bit terse :)
Have I done right?
Original comment by [email protected]
on 9 Jan 2009 at 8:58
from distcc.
You did great! Thanks!!
Original comment by [email protected]
on 9 Jan 2009 at 10:51
from distcc.
Original comment by [email protected]
on 9 Jan 2009 at 10:51
- Changed state: Fixed
from distcc.
Related Issues (20)
- Compilation fails under Cygwin HOT 2
- --coverage flag not treated correctly HOT 1
- missing feature: support --coverage to compile remotely HOT 1
- ls HOT 1
- Apparently not getting much parallelism HOT 9
- [deleted issue]
- Include server not covering... HOT 6
- GPL3 encumbrance HOT 9
- disable distcc HOT 3
- unknown translation unit - mips64 compiler HOT 4
- Building with GCC 4.7.3 on x86_32 fails due to warnings in lzo/minilzo.c HOT 3
- Documentation for --random is incomplete
- lsdistcc_1.html Shown as Raw File in Browser HOT 1
- zeroconf hosts have a hardcoded slots value of 4? HOT 2
- OS X Yosemite Compile Fixes
- absence of DISTCC_SSH setting causes exec("ssh") failure HOT 1
- lsdistcc segfaults when called with more than 502 hosts
- [PATCH] SOCKSv5 proxy support HOT 2
- distccd not honoring DISTCC_TCP_CORK=0
- gnome/distccmon-gnome.desktop is not utf-8 encoded file.It is ISO-8859.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from distcc.