Comments (9)
I don't think the patch really addresses the underlying issue.
It just replaces a possible use of an uninitialized variable
with a possible dereference of a null pointer.
It fixes the build error, but doesn't fix the possible run-time error.
Original comment by [email protected]
on 2 Dec 2008 at 6:49
from distcc.
Original comment by [email protected]
on 8 Dec 2008 at 11:39
- Added labels: Type-Defect
from distcc.
Surely this is simply fixed by making the call to dcc_note_state() conditional
on ret == 0? I would initialize chosen to NULL too, just as good practice.
Original comment by [email protected]
on 25 Sep 2010 at 1:37
from distcc.
hi,
I guess I can post similar issue here when I try to make distcc on my iMac:
Darwin bjchenys-iMac 11.0.0 Darwin Kernel Version 11.0.0: Sat Jun 18 12:56:35
PDT 2011; root:xnu-1699.22.73~1/RELEASE_X86_64 x86_64
gcc version 4.2.1 Python 2.7.1
bjchenys-iMac:distcc bjcheny$ make
echo "path: $PATH"
path: /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin
./config.status
config.status: creating Makefile
config.status: creating popt/.stamp-conf
config.status: creating lzo/.stamp-conf
config.status: creating pump
config.status: creating src/config.h
config.status: src/config.h is unchanged
touch src/config.h.stamp
gcc -DHAVE_CONFIG_H -D_GNU_SOURCE -DSYSCONFDIR="\"/usr/local/etc\""
-DPKGDATADIR="\"/usr/local/share/distcc\"" -Isrc -I"./src" -I"./lzo" -I"./popt"
-Werror -g -O2 -MD -W -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align
-Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes
-Wnested-externs -Wmissing-declarations -Wuninitialized -D_THREAD_SAFE -o
src/hosts.o -c src/hosts.c
cc1: warnings being treated as errors
src/hosts.c: In function 'dcc_parse_hosts':
src/hosts.c:562: warning: implicit declaration of function 'strndup'
src/hosts.c:562: warning: incompatible implicit declaration of built-in
function 'strndup'
make: *** [src/hosts.o] Error 1
I wonder any progress/patch or general solution for this kind of issue?
Regards
Original comment by [email protected]
on 30 May 2012 at 12:34
from distcc.
Forget to add I use to get code:
svn checkout http://distcc.googlecode.com/svn/trunk/ distcc-read-only
Original comment by [email protected]
on 30 May 2012 at 12:37
from distcc.
The general work-around for compiler warnings is to configure with
"--disable-Werror".
Original comment by [email protected]
on 30 May 2012 at 3:43
from distcc.
> src/where.c: In function 'dcc_lock_local_cpp':
> src/where.c:193: error: 'chosen' may be used uninitialized in this function
> make: *** [src/where.o] Error 1
The error only occurs when using "-O3".
> Surely this is simply fixed by making the call to
> dcc_note_state() conditional on ret == 0?
Any reason not to apply this fix? It makes sense.
Original comment by [email protected]
on 8 May 2013 at 2:49
- Changed state: Accepted
from distcc.
The proposed fix of making the call to dcc_note_state() conditional on ret == 0
sounds good to me.
Original comment by [email protected]
on 8 May 2013 at 3:56
from distcc.
This issue was closed by revision r779.
Original comment by [email protected]
on 10 May 2013 at 2:36
- Changed state: Fixed
from distcc.
Related Issues (20)
- Compilation fails under Cygwin HOT 2
- --coverage flag not treated correctly HOT 1
- missing feature: support --coverage to compile remotely HOT 1
- ls HOT 1
- Apparently not getting much parallelism HOT 9
- [deleted issue]
- Include server not covering... HOT 6
- GPL3 encumbrance HOT 9
- disable distcc HOT 3
- unknown translation unit - mips64 compiler HOT 4
- Building with GCC 4.7.3 on x86_32 fails due to warnings in lzo/minilzo.c HOT 3
- Documentation for --random is incomplete
- lsdistcc_1.html Shown as Raw File in Browser HOT 1
- zeroconf hosts have a hardcoded slots value of 4? HOT 2
- OS X Yosemite Compile Fixes
- absence of DISTCC_SSH setting causes exec("ssh") failure HOT 1
- lsdistcc segfaults when called with more than 502 hosts
- [PATCH] SOCKSv5 proxy support HOT 2
- distccd not honoring DISTCC_TCP_CORK=0
- gnome/distccmon-gnome.desktop is not utf-8 encoded file.It is ISO-8859.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from distcc.