Comments (19)
@Marlysson I'm not sure. @corentinalcoy will have to comment. If hes not working on it i'll assign it to you
from orm.
@josephmancuso can I have this one?
from orm.
Yes. The API should look like this: https://orator-orm.com/docs/0.9/schema_builder.html#dropping-indexes
from orm.
I think you should add index
, primary
functions before to complete this issue
from orm.
for adding constraints?
from orm.
Yes
from orm.
Yes @Marlysson is working on something here #46
from orm.
I thought that he works just on foreign keys.
I am talking about this https://orator-orm.com/docs/0.9/schema_builder.html#adding-indexes
from orm.
You are right. we have primary keys already but we may need to add normal indexes first
orm/tests/schema/mysql/test_mysql_schema.py
Line 265 in bb26afa
from orm.
You are right. we have primary keys already but we may need to add normal indexes first
orm/tests/schema/mysql/test_mysql_schema.py
Line 265 in bb26afa
The simple MySQL request to a drop primary key is alter table table_name drop primary key
I don't get why we need to pass an argument to drop_primary
from orm.
I can add index methods
from orm.
@corentinalcoy Ok awesome you can work on this issue #76
from orm.
You are right. we have primary keys already but we may need to add normal indexes first
orm/tests/schema/mysql/test_mysql_schema.py
Line 265 in bb26afa
The simple MySQL request to drop primary key is
alter table table_name drop primary key
I don't get why we need to pass an argument todrop_primary
@josephmancuso And this?
from orm.
hmm not sure. You can have multiple columns as a primary key though. For now I guess just build no parameters going to it and later we can add support for things like composite keys
from orm.
@josephmancuso On #46 I'll add constraints and drop index of type foreign key.
With #76 created ( talking about unique index ), how to handle the unique constraint already created? Who does this, he will make git pull before?
from orm.
All these things can really happen at the same time. We just need to make sure the format is correct
from orm.
@corentinalcoy If you aren't working in this... @josephmancuso can you assign me to this?
from orm.
I am testing...
It will be done in a few hours
from orm.
@josephmancuso
I found some 'errors' in the project.
I will show when I will turn on my computer..
from orm.
Related Issues (20)
- `QueryBuilder.update()` does not respect model `__casts__` HOT 6
- Add update_or_create to QueryBuilder
- Datetime fields returning type is not consistant. HOT 5
- Add complete type definitions HOT 1
- masoniteorm.query.QueryBuilder.QueryBuilder.create() HOT 12
- Ability to define custom computed properties on models HOT 2
- __fillable__ and __guarded__ are mutually exclusive... why? HOT 4
- Little issue in first_or_create method HOT 3
- Automatically remember the user who created or updated HOT 1
- TypeError exception when running `seed:run` HOT 2
- Where with None values
- Error trying to save Json in version 2.19.* HOT 1
- Implement migrate:fresh
- Allow for specifying a config path when using ConnectionResolver
- Change default folder
- Changing a column on sqlite from integer to varchar removes data types on unsigned integer columns
- Add min to collection. HOT 1
- Postgres psycopg2 TLS connectivity HOT 1
- Update to Pendulum 3 HOT 1
- Add JSON structure to where clause.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orm.