Git Product home page Git Product logo

Comments (19)

josephmancuso avatar josephmancuso commented on August 22, 2024 1

@Marlysson I'm not sure. @corentinalcoy will have to comment. If hes not working on it i'll assign it to you

from orm.

corentinalcoy avatar corentinalcoy commented on August 22, 2024

@josephmancuso can I have this one?

from orm.

josephmancuso avatar josephmancuso commented on August 22, 2024

Yes. The API should look like this: https://orator-orm.com/docs/0.9/schema_builder.html#dropping-indexes

from orm.

corentinalcoy avatar corentinalcoy commented on August 22, 2024

I think you should add index, primary functions before to complete this issue

from orm.

josephmancuso avatar josephmancuso commented on August 22, 2024

for adding constraints?

from orm.

corentinalcoy avatar corentinalcoy commented on August 22, 2024

Yes

from orm.

josephmancuso avatar josephmancuso commented on August 22, 2024

Yes @Marlysson is working on something here #46

from orm.

corentinalcoy avatar corentinalcoy commented on August 22, 2024

I thought that he works just on foreign keys.

I am talking about this https://orator-orm.com/docs/0.9/schema_builder.html#adding-indexes

from orm.

josephmancuso avatar josephmancuso commented on August 22, 2024

You are right. we have primary keys already but we may need to add normal indexes first

def can_compile_primary_key(self):

from orm.

corentinalcoy avatar corentinalcoy commented on August 22, 2024

You are right. we have primary keys already but we may need to add normal indexes first

def can_compile_primary_key(self):

The simple MySQL request to a drop primary key is alter table table_name drop primary key
I don't get why we need to pass an argument to drop_primary

from orm.

corentinalcoy avatar corentinalcoy commented on August 22, 2024

I can add index methods

from orm.

josephmancuso avatar josephmancuso commented on August 22, 2024

@corentinalcoy Ok awesome you can work on this issue #76

from orm.

corentinalcoy avatar corentinalcoy commented on August 22, 2024

You are right. we have primary keys already but we may need to add normal indexes first

def can_compile_primary_key(self):

The simple MySQL request to drop primary key is alter table table_name drop primary key
I don't get why we need to pass an argument to drop_primary

@josephmancuso And this?

from orm.

josephmancuso avatar josephmancuso commented on August 22, 2024

hmm not sure. You can have multiple columns as a primary key though. For now I guess just build no parameters going to it and later we can add support for things like composite keys

from orm.

Marlysson avatar Marlysson commented on August 22, 2024

@josephmancuso On #46 I'll add constraints and drop index of type foreign key.

With #76 created ( talking about unique index ), how to handle the unique constraint already created? Who does this, he will make git pull before?

from orm.

josephmancuso avatar josephmancuso commented on August 22, 2024

All these things can really happen at the same time. We just need to make sure the format is correct

from orm.

Marlysson avatar Marlysson commented on August 22, 2024

@corentinalcoy If you aren't working in this... @josephmancuso can you assign me to this?

from orm.

 avatar commented on August 22, 2024

I am testing...
It will be done in a few hours

from orm.

 avatar commented on August 22, 2024

@josephmancuso
I found some 'errors' in the project.
I will show when I will turn on my computer..

from orm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.