Git Product home page Git Product logo

Comments (5)

GiulioRomualdi avatar GiulioRomualdi commented on May 18, 2024 2

Hi @marzer, If it's ok for you I can propose a PR with the solution described by @traversaro in #20 (comment)

from tomlplusplus.

marzer avatar marzer commented on May 18, 2024 2

@traversaro @GiulioRomualdi I've just done some minor cleanup to move the cmake stuff behind a configuration option GENERATE_CMAKE_CONFIG that defaults to auto (disabled when invoked as a submodule, enabled otherwise). It should still 'just work', but if you want to be explicit about it you can when you invoke meson, e.g.:

CXX=clang++ meson build-clang -DGENERATE_CMAKE_CONFIG=enabled

from tomlplusplus.

marzer avatar marzer commented on May 18, 2024 1

Ah, thanks @traversaro. Since I'm largely a cmake novice this may take me a while to dig into, so if you do decide to work on this yourself I'd be very grateful!

An alternative short-term workaround is to eliminate the need for build systems and subprojects completely by dropping the single-file version of the library toml.hpp in your source tree.

from tomlplusplus.

marzer avatar marzer commented on May 18, 2024 1

On an unrelated note, I just had a look at the linked issue and noticed that my use of <charconv> is problematic for you guys. Since I'm already forced to use stringstreams on some platforms, there's no significant reason why I can't add support for an entirely stringstream-based mode, if that's helpful.

from tomlplusplus.

marzer avatar marzer commented on May 18, 2024

Yup, go for it! I'm going to push a fix for the <charconv> issue and the locale issue later today, so I won't merge anything in until after that, but if it's just build configuration stuff I'm sure it'll be fairly simple to merge.

from tomlplusplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.