FR/Bug: For tools that wrap to terminal width, `jj log -p --tool` often has the tool overflow by the width of the graph about jj HOT 3 OPEN

it's hard to add an argument for terminal width to the tool arguments conditionally on whether $terminal_width is defined.

I think the width/columns parameter should be set unconditionally. jj controls the terminal, so it makes sense that the diff backend respects the width provided by jj.

from jj.

I'm mildly worried this could force wrapping when it's undesired, similarly to the problem I mentioned (and I think you referred to) in #4160 (comment).

BTW, I remembered an option 4 to add to the description, even though I'm not sure about it.

Update: This also applies to your point from #4160 about jj log --no-graph sometimes potentially used for machine-readable output. If jj log --no-graph always instructs the tool to wrap text, that would be harder.

from jj.

I'm mildly worried this could force wrapping when it's undesired,

If the backing diff tool is difft --display=side-by-side for example, shouldn't it always do line wrapping no matter if --width=$width parameter is specified or not? If the user needs some conditional, I think they can use separate tool names.

from jj.