Setup CI for checking sanity of with_tests branch about refactoring-kata-lift-pass-pricing HOT 18 CLOSED

Test branch could also always merge against master. there are conflicts we have to do something

from refactoring-kata-lift-pass-pricing.

Hi Johan

is this still an open issue? I'd like to implement a github-action for this issue. I'd start with Java

from refactoring-kata-lift-pass-pricing.

Yes please do. I can review your changes then

from refactoring-kata-lift-pass-pricing.

Alright mission completed :-) I need to prepare a PR. The changes are not just about adding the workflow action, need to fix the mysql driver and the unit-test startup.

You'll find the unit-test startup fix in this PR:
#47

I'd suggest to merge this PR first and then I'll create a new one based on this. Or do you have another suggestion?

from refactoring-kata-lift-pass-pricing.

By the way a csharp implementation of the workflow should be easy as soon as the Java actions are available. So I'd continue to implement the same for csharp.

from refactoring-kata-lift-pass-pricing.

from refactoring-kata-lift-pass-pricing.

Just completed the csharp pipeline. So how should I split up the PRs? What do we want to merge into the master branch?

from refactoring-kata-lift-pass-pricing.

Just completed the csharp pipeline. So how should I split up the PRs? What do we want to merge into the master branch?

Why I'm asking? First, the changes can be merged into the master branch easily. The code will not be executed on master, because I added a filter. But the master and with_test branch are out of sync. So I believe that merging from master to with_test won't be easy at all. Second, I need two additional changes, which don't relate to the feature but must be fixed upfront:

1. The JUnit test should start the spark server only once
2. An upgrade of the mysql-connector-java version to 8.0.28 (see https://stackoverflow.com/questions/53131321/spring-boot-jdbc-javax-net-ssl-sslexception-closing-inbound-before-receiving-p/53136942#53136942)

from refactoring-kata-lift-pass-pricing.

Merge to master is good idea. It should be possible from with-tests. I recommend one large pr for with-tests branch. Merge is a separate task we can do afterwards. I believe there are also things missing on with-tests

from refactoring-kata-lift-pass-pricing.

Hi how could I make this easier? By merging master into with_tests to make it up to date?

from refactoring-kata-lift-pass-pricing.

@martinsson Johan maybe first drop the PR's which want to bump versions - unless you want that. I usually deactivate Security scans in kata projects. Second please accept or reject other open pull requests. I commented on PRs for that.

Also there is a simplify C# branch, can it be brougt to master in separate folder like java-simple? That would be great.

from refactoring-kata-lift-pass-pricing.

@rolger could you also add actions for java-simple and csharp-simple when available. In fact everything should be tested, also Scala and PHP and such. I have many github integrations in https://github.com/codecop/Parrot-Refactoring-Kata/tree/github-build

from refactoring-kata-lift-pass-pricing.

@codecop I'll have a look at them.

By the way CSharp needs an upgrade. The .Net version is not supported anymore.

from refactoring-kata-lift-pass-pricing.

@martinsson Johan maybe first drop the PR's which want to bump versions - unless you want that. I usually deactivate Security scans in kata projects. Second please accept or reject other open pull requests. I commented on PRs for that.

Good point

Also there is a simplify C# branch, can it be brougt to master in separate folder like java-simple? That would be great.

I'll have a look at that

from refactoring-kata-lift-pass-pricing.

@codecop I'll have a look at them.

By the way CSharp needs an upgrade. The .Net version is not supported anymore.

@martinsson: maybe you open a new issue for that. I can fix it.

from refactoring-kata-lift-pass-pricing.

I believe the issue can be closed. There are build scripts for all languages for the with_tests branch.

The scripts could be added and commited to the master branch, because they are matching only on the with_tests branch.

from refactoring-kata-lift-pass-pricing.

Brilliant @rolger :)

from refactoring-kata-lift-pass-pricing.

Done by #52

from refactoring-kata-lift-pass-pricing.